Hi Danek,
See my comments below.
I have made the changes to the patch, and here is a webrev diff from
last time:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/s11-u1-ruby/webrev-3-diffs/
and a full webrev:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/s11-u1-ruby/webrev-3/
thanks,
April
On 2/9/2012 4:39 PM, april.c...@oracle.com wrote:
Thanks for reviewing, Danek!
See below.
April
On 2/9/2012 4:08 PM, Danek Duvall wrote:
april.c...@oracle.com wrote:
Could I please get a code review to fix:
7127211 problem with ruby
http://monaco.us.oracle.com/detail.jsf?cr=7127211
The webrev is here:
http://http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/s11-u1-ruby/webrev-1/
02-code_objects-html_generator.patch:
- Is this affected by the locale? That is, do you get a different
result
if you use C rather than en_US.UTF-8? That's definitely been an
issue
for sorting in the past.
Good question. I'll check this out and let you know.
The module/class name values being sorted from the rubygems source are all
alphanumeric, all starting with an upper-case alphabetic character, as
is the norm
for class names. So the differences between C and en_US locales in sorting
upper- and lower-case make no difference here.
I tested building with the locale en_US.UTF-8, and the file names came out
the same as with the C locale. So this should be okay.
- line 34, 46: I wouldn't keep commented-out code in the file.
Okay, I'll remove the commented out old code.
Danek
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
