Hey Rich,
I'm satisfied with the changes and I think you've got a good match
between the license files and the tool entries.
Thanks,
Kevin.
On 03/ 8/12 09:24 AM, Rich Burridge wrote:
Hi Kevin,
I see nothing wrong with your changes - except areca probably needs
an update, see below:
-TPNO#'s look right
-nothing added/changed that looks incorrect
-your one change to a .p5m file looks good, etc.
That being said I've noted the minor diffs from your license text
changes compared to whats in the tracking tool. I'd even argue that
your non-changes are typically better (wrapped lines, blank lines vs
the tool that did not wrap lines or were missing blank lines in some
cases, etc.) Still, I noted the diffs just for the sake of being
thorough.
If you update areca (or ping legal on it?) I'd give these changes a
thumbs up, the rest is your call.
Apart from an extra blank line and line wrapping differences, I've
updated all
the ones you mention (see more details below).
New webrev at:
http://jurassic.sfbay/~richb/TPNO_changes-v2/
Thanks!
areca:
-note that the license tool has this for the first 2 lines:
Copyright 2005-2009, Olivier PETRUCCI.
This program is distributed under the GNU General Public License v2.
while the first 2 lines of the license are:
Copyright 2005-2009, Olivier PETRUCCI
<aven...@users.sourceforge.net>
{ a blank line, no actual text }
I've adjusted "areca.copyright" to have the two lines from
the license tool text.
-also, address has changed, the license tool has the new address (
http://www.fsf.org/about/contact/ ):
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
while the license file has the old address:
675 Mass Ave, Cambridge, MA 02139, USA
and the address differs again further down in the license file. If
there
are other minor differences I do not see them.
Address changed in those two places.
autogen:
-matches what is in the license tool.
ilmbase:
-Looks like the license tool has the first line as:
OPENEXR:
Otherwise the license file matches what is in the license tool.
I've added the "OPENEXR:" line (plus extra blank line).
iperf:
-matches what is in the license tool.
libmng:
-the license tool Attribution Requirement Note does not have the long
/*******/
header and footer lines.
Otherwise the license file matches what is in the license tool.
I've removed the first and last long /*******/ line. It still has the
middle one
(same as the license text in the license tool).
libxml2:
-license tool does not include a blank line where the license file
has one
at line 29. Otherwise the license file matches what is in the
license tool.
I'm leaving that extra blank line in there. It make the text more
readable.
libxslt:
-matches what is in the license tool.
lighttpd:
-matches what is in the license tool.
lua:
-The license tool Attribution Requirement Note does not seem to have
blank
lines and has no wrapping of text at 80-ish characters as might be
expected.
Otherwise the text seems to match.
Agreed. I'm going to go with the version that's in the license file
(i.e. with extra line breaks).
openexr:
-Looks like the license tool has the first line as:
OPENEXR:
Otherwise the license file matches what is in the license tool.
I've added the "OPENEXR:" line (plus extra blank line).
swig:
-matches what is in the license tool.
tcpdump:
-matches what is in the license tool.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
