Danek Duvall said the following on 08/24/2012 08:31 PM:
Pavel Heimlich wrote:
refreshed webrev is at
http://votice.cz.oracle.com/webrev/20120824-pheimlic-ips0Timezone/
system-data-timezone.p5m:
- Any particular reason you're still prefixing the version with 0.?
I forgot about the new versioning scheme, sorry
fixed
system-data-timezone-message-files.p5m:
- Same here.
- lines 30-32: Although "True" should work, convention is lowercase:
"true".
fixed
The updated webrev is at
http://votice.cz.oracle.com/webrev/20120827-pheimlic-ips0Timezone/
a diff from the previous version:
< --- /dev/null Fri Aug 24 06:01:49 2012
< +++ new/components/timezone/system-data-timezone-message-files.p5m Fri Aug 24
06:01:48 2012
---
> --- /dev/null Mon Aug 27 01:34:06 2012
> +++ new/components/timezone/system-data-timezone-message-files.p5m Mon Aug 27
01:34:06 2012
28c28
< +
value=pkg://$(PUBLISHER_LOCALIZABLE)/system/data/timezone-message-files@0.$(PKG_SOLARIS_VERSION),$(BUILD_VERSION)
---
> +
value=pkg://$(PUBLISHER_LOCALIZABLE)/system/data/timezone-message-files@$(PKG_SOLARIS_VERSION),$(BUILD_VERSION)
33,35c33,35
< +set name=pkg.linted.pkglint.manifest010.2 value=True
< +set name=pkg.linted.opensolaris.manifest001.1 value=True
< +set name=pkg.linted.userland.manifest001.0 value=True
---
> +set name=pkg.linted.pkglint.manifest010.2 value=true
> +set name=pkg.linted.opensolaris.manifest001.1 value=true
> +set name=pkg.linted.userland.manifest001.0 value=true
44,45c44,45
< --- old/components/timezone/system-data-timezone.p5m Fri Aug 24
06:01:50 2012
< +++ new/components/timezone/system-data-timezone.p5m Fri Aug 24
06:01:49 2012
---
> --- old/components/timezone/system-data-timezone.p5m Mon Aug 27
01:34:07 2012
> +++ new/components/timezone/system-data-timezone.p5m Mon Aug 27
01:34:06 2012
51c51
< + value=pkg:/system/data/timezone@0.$(PKG_SOLARIS_VERSION),$(BUILD_VERSION)
---
> + value=pkg:/system/data/timezone@$(PKG_SOLARIS_VERSION),$(BUILD_VERSION)
Thanks
P.
Thanks,
Danek
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
