Thanks David. I didn't realize that the syntax for setting properties makes such a difference. Although it seems like subtle trivia, it's really important! 2173 is now closed.

Josh

David Bosschaert wrote:
Hi Josh,

I've just committed a further fix for this. I've also added a
Declarative Services demo to the samples directory (
http://svn.apache.org/repos/asf/cxf/dosgi/trunk/samples/ds ) which can
be used to play with this stuff. I tested it with the DS
implementation that comes with Equinox 3.5M6.

One thing to note when using DS... There is a subtle difference
between the following two lines:
  (1) <property name="myKey">myVal</property>
  (2) <property name="myKey" value="myVal" />

In (1) myVal is stored in a String [] on the service registration
while in (2) myVal is stored as a simple String.
In CXF/DOSGi some of the properties are expected to be of type String,
so in some cases syntax (2) is required, e.g the following works for
me:
  <property name="osgi.remote.interfaces">*</property>
  <property name="osgi.remote.configuration.type" value="pojo" />
  <property name="osgi.remote.configuration.pojo.address"
value="http://localhost:9090/adder"; />

I've marked bug 2173 as fixed, please close if it works for you too.

Cheers,

David


2009/5/19 David Bosschaert <[email protected]>:
Thanks Josh. I've reopened the issue and will investigate further.

David

2009/5/19 Josh Holtzman <[email protected]>:
Great, thanks David.  I was pretty sure my patch was wrong, and I appreciate
you taking the time to do this correctly.  Unfortunately, I'm still having
trouble getting declarative services to work.  I'll post more details to the
Jira ticket itself.

Thanks,
Josh




David Bosschaert wrote:
Hi Josh,

Just to let you know that I committed a fix for this. Please close the
bug if it works for you.

David

2009/5/11 Josh Holtzman <[email protected]>:

Great, thanks David!

Josh

David Bosschaert wrote:

Hi Josh,

An email like this one is great  - thanks! I didn't spot your patch
before. I will have a look as soon as possible, hopefully sometime
this week. In the mean time I've assigned the bug to myself so I won't
forget about it :)

Cheers,

David

2009/5/11 Josh Holtzman <[email protected]>:


I've got a procedural question regarding submission of patches.  Last
week I
attached a patch to address CXF-2173, but there has been no discussion
on
that issue in Jira and the bug remains unassigned.  Should I have sent
an
email to the users list asking for review of the patch?  Should I just
be
more patient and wait until a committer picks up the issue?  I don't
want
to
be pushy... I'm just wondering what happens next.

Thanks,
Josh

--
Josh Holtzman
Educational Technology Services, UC Berkeley
[email protected]
510.529.9225




--
Josh Holtzman
Educational Technology Services, UC Berkeley
[email protected]
510.529.9225



--
Josh Holtzman
Educational Technology Services, UC Berkeley
[email protected]
510.529.9225



--
Josh Holtzman
Educational Technology Services, UC Berkeley
[email protected]
510.529.9225

Reply via email to