Hi Dan. Thanks for the feedback.
The utilities methods could be moved to IOUtils, FileUtils, whichever you like -- I can do that. I guess the bigger question is if you think the interface is worthwhile. For us it's very useful since we're uploading large files (>5G) and the cost of moving that data around is considerable. File moves, therefore, are a nice win. I would have thought this might be useful to others too. FWIW, this is the Spring interface I've copied: http://docs.spring.io/spring/docs/1.2.x/api/org/springframework/web/multipart/MultipartFile.html#transferTo(java.io.File) Anyway, let me know if you have any more thoughts on the viability of this functionality. Henry On 10 Jan 2014, at 15:58, Daniel Kulp <[email protected]> wrote: > > On Jan 10, 2014, at 8:54 AM, Henry Clout <[email protected]> wrote: > >> Hi Sergey. >> >> I've created a patch to implement the transferTo(File) functionality Graham >> was describing. >> >> https://issues.apache.org/jira/browse/CXF-5489 > > Just a quick look at the patch. Likely not something we’d apply. We have a > few util classes already that handle some of this. IOUtils, FileUtils, etc… > Not really sure we need the interface for this either. Need to think about > that part a bit more. > > Dan > > >> It's not the *most* beautiful thing I've ever written, but it's the best I >> could do whilst keeping to the interface contracts. I've tested it against >> 2.7.5 which is what we're using with our app, the patch is for the current >> trunk build. >> >> Could you let me know if this is something that could be included in the >> codebase please? >> >> Thanks, >> >> Henry >> >> >>> >>> ---------- Forwarded message ---------- >>> From: Sergey Beryozkin <[email protected]> >>> Date: 7 January 2014 11:57 >>> Subject: Re: Accessing temporary file name of attachments >>> To: "[email protected]" <[email protected]> >>> >>> >>> Hi >>> It may make sense indeed to simplify an access to the underlying temp file >>> or perhaps make the naming more configurable, >>> I'm not sure yet how this can be done but hope we can come up with some >>> solution >>> Thanks, Sergey >>> >> > > -- > Daniel Kulp > [email protected] - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com -- Henry Clout Software Engineer Kulu Valley Ltd 91 Goswell Road London EC1V 7EX Direct: +44 (0) 207 017 8322 Mobile: +44 (0) 777 576 2963 Office: +44 (0) 207 253 8080 www.kuluvalley.com — The Information contained in this e-mail and any attached files are intended for the named recipient(s) only. It may contain legal, privileged and/or confidential information and if you are not an intended recipient, you should not copy, distribute or take any action in reliance on it or disclose its contents. If you have received this e-mail in error, please notify the sender immediately and then delete it. Internet e-mail is not a secure medium. Any reply to this message could be intercepted and read by someone else. Please bear that in mind when deciding whether to send material in response.
