On 17.08.2016 14:48, Sergey Beryozkin wrote:
On 17/08/16 13:36, Christian Schneider wrote:
I think logging is not a core element of CXF so I would like to move it
out of cxf core. This is why I created the new logging in a separate
module.
that is fine, you mean rt/features/logging, it is fine
3.2.0 is a minor release. So I am not sure if we should remove something
like logging from core in this release. We could try to merge the old
and new logging but I think it might be better to just deprecate the old
logging and leave it unchanged.
3.2.0 is a major release as far as I know, even though it is not
4.0.0, it is strictly Java8, we just do not have that many new
features to mark it as 4.0.0 - but fingers crossed it will have early
JAX-RS 2.1, etc. It is a major release AFAIK
I agree changing to pure java 8 could make it a major version. In that
case I would name it 4.0.0 thought. I think a major version is not
defined by the features you add but rather by the features you remove or
change. Adding features never requires a major version. I know marketing
people think differently but luckily we are an open source project were
marketing is not first priority :-)
For a major version I fully agree to remove the old logging support.
I am aware that duplicating stuff is not good generally but as I would
just remove the old logging in the next major release I think this might
be ok.
+1 to remove one of the two available set of loggers.
Lets keep your new loggers they are more advanced.
In 3.2.0 IMHO it is the right time to get rid of the old code and keep
your new code only - otherwise we will need to continue fixing issues
for both sets of loggers and it will be a mess :-)
In case of a major realise I agree to remove the old logging code. If
you look into the cxf core jar then you see that the
logging is located in org.apache.cxf.interceptor and
org.apache.cxf.feature. These packages are very generic and can not be
moved outside of core. So I think there is no good way to extract the
logging from core while keeping the same package.
Letting the old classes extend the new ones is also not possible as core
can not depend on the logging feature jar.
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
http://www.talend.com
