Adding a check for Exclude would make sense and be easy.  Adding Vetoed,
since we're still CDI 1.0, would be hard.  I just put in
https://issues.apache.org/jira/browse/DELTASPIKE-1311 and can plan to take
care of that for you in 1.8.2.

Thanks for the info, and thanks for the clarifications!

John

On Fri, Jan 5, 2018 at 7:39 AM Thomas Andraschko <
[email protected]> wrote:

> Yep, i see. AbstractEntityRepository has a @Repository of course.
> We could of course add a check for @Vetoed/Exclude but not sure if it has
> any side effects.
>
> 2018-01-05 13:31 GMT+01:00 Ivo Limmen <[email protected]>:
>
> > I did. Since my AbstractMultitenancyRepository extends
> > AbstractEntityRepository it is included as a "real" repository; even
> though
> > it has no @Repository.
> >
> > Best regards,
> > Ivo Limmen
> >
> > On Fri, Jan 5, 2018 at 1:24 PM, Thomas Andraschko <
> > [email protected]> wrote:
> >
> > > It actually shoudln't if there is no @Repository present. Could you
> debug
> > > RepositoryExtension#isRepository?
> > >
> > >
> > > 2018-01-05 13:20 GMT+01:00 Ivo Limmen <[email protected]>:
> > >
> > > > Yes it is.
> > > >
> > > > Best regards,
> > > > Ivo Limmen
> > > >
> > > > On Fri, Jan 5, 2018 at 1:19 PM, John D. Ament <
> [email protected]>
> > > > wrote:
> > > >
> > > > > Ivo,
> > > > >
> > > > > You should not add @Repository to this class.  Is it still
> discovered
> > > > then?
> > > > >
> > > > > John
> > > > >
> > > > > On Fri, Jan 5, 2018 at 7:12 AM Ivo Limmen <[email protected]> wrote:
> > > > >
> > > > > > Hi John,
> > > > > >
> > > > > > I am trying to AVOID discovery of the repository as it is a
> > abstract
> > > > base
> > > > > > repository with common utility methods. I tried by adding
> > @Repository
> > > > but
> > > > > > it does not work.
> > > > > > I tried adding @Exclude on the repository but the
> > RepositoryExtension
> > > > > does
> > > > > > not filter on @Exclude annotated repositories.
> > > > > >
> > > > > > Best regards,
> > > > > > Ivo Limmen
> > > > > >
> > > > > > On Fri, Jan 5, 2018 at 1:09 PM, John D. Ament <
> > > [email protected]>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Ivo,
> > > > > > >
> > > > > > > For any repository to be discovered, it should be annotated
> > > > > @Repository.
> > > > > > > If this is your own custom class, I would simply remove that
> > > > > annotation.
> > > > > > >
> > > > > > > John
> > > > > > >
> > > > > > > On Fri, Jan 5, 2018 at 6:42 AM Ivo Limmen <[email protected]>
> > wrote:
> > > > > > >
> > > > > > > > Hi list,
> > > > > > > >
> > > > > > > > I am using DeltaSpike for my project and I like it very much.
> > > But I
> > > > > am
> > > > > > > > trying to exclude an abstract repository (my own abstract
> base
> > > > > > > repository)
> > > > > > > > from being picked up by the RepositoryExtention.
> > > > > > > > I tried @Exclude but that does not work. Then I discovered
> that
> > > > 1.8.1
> > > > > > was
> > > > > > > > release (I used 1.8.0) but that did not help either.
> > > > > > > > I saw that the method RepositoryExtension.isRepository() does
> > > not
> > > > > > > exclude
> > > > > > > > any interfaces or abstract classes; it this feature missing?
> > > > > > > > Or am I using it wrong?
> > > > > > > >
> > > > > > > > Best regards,
> > > > > > > > Ivo Limmen
> > > > > > > >
> > > > > > > > --
> > > > > > > > Met vriendelijke groet,
> > > > > > > > Ivo Limmen
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Met vriendelijke groet,
> > > > > > Ivo Limmen
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Met vriendelijke groet,
> > > > Ivo Limmen
> > > >
> > >
> >
> >
> >
> > --
> > Met vriendelijke groet,
> > Ivo Limmen
> >
>

Reply via email to