On 23/12/2007, Carsten Ziegeler <[EMAIL PROTECTED]> wrote: > > I discovered one issue just recently with the bundleplugin and the jar > plugin. I have to further investigate, but it seems that the > bundleplugin removes manifest entries that have been explicitly set by > the jar plugin.
if the packaging is set to "bundle" then the bundleplugin will replace the jar plugin in the build lifecycle, as the Bnd tool builds the final artifact jar. So I don't immediately see how the bundleplugin can remove entries set by the jar plugin, as the jar plugin is not involved in creating the bundle... unless you mean wrapping existing jars as bundles? (like Felix commons) but then the bundleplugin should already keep any manifest entries from the original wrapped jarfile. or do you mean does the bundleplugin look at the jar plugin configuration? if so then the answer is no, it does not: changing the packaging from "jar" to "bundle" switches in a different packaging process which doesn't involve the jar plugin. should the bundleplugin pick up manifest entries also specified in the jar plugin config? - this could be convenient, but it could also be confusing if users don't expect it (ie. why does this appear in the manifest if I didn't ask the bundleplugin to add it...) It would be great to look into/fix this issue first as this is a > blocking issue for using the bundleplugin with all apache commons > subprojects. I'll have a look at this tomorrow. it's a simple patch if this is what you're looking for, as I've done this for other Maven plugins in the past... but we'd need to make sure people were aware that manifest entries set under the jar plugin configuration would appear in the bundle - and stress that (at the moment) other jar plugin specific settings are *not* honoured by the bundleplugin Carsten > > Stefano Lenzi wrote: > > +1 for release > > > > Stefano "Kismet" Lenzi > > > > > > Stuart McCulloch wrote: > >> Hi folks, > >> > >> Carlos has released the maven-dependency-tree and maven-osgi shared > >> components (thanks Carlos!) > >> which means there are no more external snapshot dependencies blocking > >> release of the bundleplugin. > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > Carsten Ziegeler > [EMAIL PROTECTED] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Cheers, Stuart
