Suggested patch available for testing / comments at: https://issues.apache.org/jira/browse/FELIX-442
Merry Christmas :) On 24/12/2007, Carsten Ziegeler <[EMAIL PROTECTED]> wrote: > > Stuart McCulloch wrote: > > > > if the packaging is set to "bundle" then the bundleplugin will replace > the > > jar plugin in the build lifecycle, as the Bnd tool builds the final > artifact > > jar. > > So I don't immediately see how the bundleplugin can remove entries set > > by the jar plugin, as the jar plugin is not involved in creating the > > bundle... > > > > unless you mean wrapping existing jars as bundles? (like Felix commons) > > but then the bundleplugin should already keep any manifest entries from > > the original wrapped jarfile. > > > > or do you mean does the bundleplugin look at the jar plugin > configuration? > :) I didn't investigate further, I ran the plugin on some commons > artifacts and the meta entries defined for the jar plugin where not in > the final jar (built by the bundleplugin). > Yes, the packaging is set to "bundle" and therefore my assumption was > obviously wrong as the jar plugin is not run in this case. At first it > seems desirable to make the bundleplugin read the jar plugin config and > use it. > > > should the bundleplugin pick up manifest entries also specified in the > jar > > plugin config? - this could be convenient, but it could also be > confusing > > if users don't expect it (ie. why does this appear in the manifest if I > > didn't > > ask the bundleplugin to add it...) > Hmm, yes, I'm not sure. > > > > > it's a simple patch if this is what you're looking for, as I've done > this > > for > > other Maven plugins in the past... but we'd need to make sure people > > were aware that manifest entries set under the jar plugin configuration > > would appear in the bundle - and stress that (at the moment) other jar > > plugin specific settings are *not* honoured by the bundleplugin > I think it would be great to have this option as it would allow to set > manifest headers at one place (jar plugin configuration) and these > values get applied regardless if the packaging is bundle or jar. > > What about making this configurable in the bundleplugin? > > > Carsten > -- > Carsten Ziegeler > [EMAIL PROTECTED] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Cheers, Stuart
