Hi Dave, I found the section where the static buffer is defined. I'm thinking on the best way to handle this for the patch. Having a static buffer is fine especially for the size it is. Properly handling variables that exceed this limit is where the issue is. I'll work on it and get back to thru the bug tracking system.
Thanks, Ed -----Original Message----- From: Dave Love [mailto:[email protected]] Sent: Saturday, August 17, 2013 12:39 PM To: 'Ed Lauzier' Cc: [email protected], [email protected] Subject: Re: [SGE-discuss] variable getting truncated in soge8.1.3 and OGS 2011.11p1 Ed Lauzier writes:> Hi,>> I'm testing the following:>> On soge 8.1.3 and OGS 2011.11p1 ( RHEL 6.3 64bit )>> 1. create an env variable 48895 chars in size. ( chars 0-9 and "/"s only )> 2. qrsh -cwd -V works> 3. qsub -cwd -V does not work ( truncates to 9990 chars )>> The above numbered items works on SGE 6.2u5 for both qrsh and qsub. ( RHEL 5.3 64bit )[It's useful to record bugs in the issue tracker.]Are you sure it's a regression? I'm surprised because the fix fornewlines in values, which must be the relevant change, didn't introducea fixed buffer.[It should be obvious which patch is common between SGE and OGS thatmust be responsible, but OGS copied it without credit and removed acomment, so that the patch doesn't match.]Why do you need such huge values anyway? They won't be without cost inSGE, and I wouldn't be surprised if they get truncated somewhere else,at least when being reported.Look at dstring for arbitrary length strings.> The reference seems to show that there may be an issue with the way a similar issue> was patched by Sun in the past.> http://gridengine.org/pipermail/users/2011-December/002113.htmlThe newline problem was never fixed properly by Sun. If you worry aboutliteral \ns in values, I fixed that, but look in the developmentversion, as the original patch checked in somehow wasn't the one Itested.-- Community Grid Engine: http://arc.liv.ac.uk/SGE/
_______________________________________________ users mailing list [email protected] https://gridengine.org/mailman/listinfo/users
