Le Mardi, Mars 10, 2020 10:07 CET, Clément David <[email protected]> a écrit: > Hi Antoine, > > Did you already setup a git repository and its pushurl to > codereview.scilab.org ? If not, please follow https://wiki.scilab.org/gerrit . >
OK, thanks for the pointer. > If yes, for small changes like pol2cart(), you could simply push the macro, > the help page and a unit test ; we will then start the discussion on the code > and merge it. For more important changes (multiple functions, modules, Scilab > global behavior, etc...) it should be good to write a SEP for better, > long-term, information. > That makes sense. Is there any wiki/doc documenting the whole process? > Note: I did not look for any equivalent function but it looks strange to me > to not already have it. Well, I first relied on what m2sci said. I had a quick glance but did not find anything. I'll have another look, it's maybe that m2sci is not aware of such a function. Thank you, Antoine > > Thanks, > > -- > Clément > > > -----Original Message----- > > From: users <[email protected]> On Behalf Of Antoine > > Monmayrant > > Sent: Tuesday, March 10, 2020 9:32 AM > > To: Users mailing list for Scilab <[email protected]> > > Subject: [Scilab-users] New function for scilab to matlab conversion > > > > Hi all, > > > > I am trying to convert some old matlab code to scilab. > > Running m2sci, I noticed that some simple functions were not available in > > scilab > > (pol2car for example). > > I just did a small clean-room reimplementation of pol2car and tested on the > > official examples that it behaves like the matlab one. > > (nothing fancy at all!). > > > > Here are my questions: > > (1) Is there any official way to propose the addition of pol2car to scilab > > ? (Not > > sure this is worth a SEP) > > (2) Is there some official coding style or additional test that I should > > provide? > > > > Thank you in advance, > > > > Antoine > _______________________________________________ > users mailing list > [email protected] > http://lists.scilab.org/mailman/listinfo/users > _______________________________________________ users mailing list [email protected] http://lists.scilab.org/mailman/listinfo/users
