> -----Original Message-----
> From: Jason van Zyl [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, July 08, 2003 1:26 AM
> To: Maven Users List
> Subject: RE: Sending mail with Maven
> 
> On Mon, 2003-07-07 at 18:36, Vincent Massol wrote:
> > Hi Brett,
> >
> > Just some thoughts. Is that something that is best placed in the test
> > plugin or would it be better placed as either a plugin in itself or as a
> > build listener (as in Ant)?
> >
> > More generally, the feature I would be looking for is: "send an email
> > when the build fails". I think this covers your use case + some others.
> >
> > Thoughts?
> 
> You guys might want to chat to Aslak as he's started a Maven continuous
> integration project called Damage Control. You could certainly do it
> with a post goal and a check but it definitely doesn't belong in the
> test plugin.
> 

I agree that this "thing" does not belong to test plugin.

The problem is that postGoal concept is very limited in that sense, 
that there can be only one preGoal/postGoal of given goal.
So IMHO adding any functionality to postGoal should be practiced only on
project level (maven.xml file) and mustn't be used on plugin level. And this
means that such extension can be hardly implemented in the way which allows
reusing them.



I have some ideas regarding "goals" for feature version of Maven
(maven-new?)

Wouldn't it be better to use goal listeners instead or pre/post goals?

e.g something like
interface GoalListeners
{
    void goalStarted(...)
    void goalFinished(...)
}


This will allow using unlimited number of goal decorators.


So there can be more tools like "build observers", and those tools.
can be used in parallel.

E.g Mail notifiers and this, what Vincent has described in his post: 
<<[Idea] Historical data and "best-behaving"/dashboard reports>>  
belongs to this category(build observers).



Other issue with goals:

I believe that we need something like "namespaces" for plugins.
This is needed if we are going to support versioned plugins (so user can
choose which version of particular plugin he wants to use). So e.g. when
user calls "ejb:ejb" goal - Maven will know that this goal is mapped to ejb
plugin. 
In next step maven will check user's preferred version of this plugin
and "load/execute" the goal from say: maven-ejb-plugin-1.1
If user has no "preferred" version of given plugin we can use always
the newest version. 



Michal

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to