> -----Original Message----- > From: Michal Maczka [mailto:[EMAIL PROTECTED] > Sent: 07 November 2003 18:01 > To: Maven Users List > Subject: RE: war plugin : [maven.caller.call.compile-java] is not defined
[snip] > > I think the aspectj aspect must be completely independent of the java > > plugin. It should be possible to replace the java plugin by the aspectj > > plugin (or by any other custom implementation) seamlessly. > > > > I fact I meant that "java:compile" is a place where java source are > compiled. > If they are compiled with javac, eclipse compiler, jikes, aspectj > (could be that aspectj compiler is as fact in compiling java sources when > no > aspect are provided as any other java compiler) > is no so important to me. Yep, except that aspects not java classes. So java:compile would not fit. However aspectj:compile would... :-) > > > You can have also things like: > > jsp:compile > ejb:compile > xmlc:compile > etc aspectj:compile > > so I think that name java:compile is quite appropriate. Nope, not for me... ;-) > > but the name of the plugin/goal is in fact of second importance here. > I am just advocating against central place when goals are "wired" > together. Which is exactly why I introduced the caller plugin. It is to unwire dependencies between plugins! :-) > > As I think that usage of preGoals/postGoals should be avoided in plugins > (it's the case right now) we should possibly try to define merge points > of the build process (as the workflow) and let other plugins be > participants of this process. Yep, but isn't this exactly what the caller plugin does? Again, I do agree that it would be better written in java and inside Maven core. I've defined a "merge point" as a WKG (Well-Known Goal). > > For me the ultimate goal would be to make entire process "clickable" so > almost no scripting in "maven.xml" file is needed yep. With the caller plugin you simply need to provide a GUI for editing the WKG properties. > > So what will be nice is to let other plugins > a) do some actions before java:compile is executed (e.g. let source > generators generate java source files) For end users, sure. For plugins I'm not sure it's really needed, provided the plugins are small and focused enough. But why not. > b) modify byte code produced by java compiler. Or replace the java plugin by your own one. BTW, this is not possible to do easily with the current aspectj version as it doesn't support weaving bytecodes on a directory (only on a jar). Hence the reason for all the above... ;-) Regards, -Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
