* John Keyes <[EMAIL PROTECTED]> [2003-11-09 04:22]:
> >>Yes but I have to specify all of the rules again in that file.  I
> >>think it should be extensible.
> >
> >I don't see why. Its a configuration file. Create your own
> >configuration. It is just as easy to copy the file and edit it.
> 
> Of course you can.  I just think its a step backwards in
> comparison to the previous version.

I didn't know the previous version. My apologies for the pedantic
comment. 

> >>>>For example, I would like to use the sun coding standard as the
> >>>>base for my coding standard and I want to change some of the
> >>>>settings.
> >>>
> >>>a) Be warned, the sun_checks.xml do not implement the sun coding
> >>>  standard.
> >>
> >>Why not?  It's bad that it doesn't work as advertised.
> >
> >Read the Sun coding standards. They don't
> >AvoidInlineConditionals, for example. The Sun coding standard
> >says nothing about DesignForExtension, since design is not an
> >aspect of formatting.  Correct your RedundantThrows and then
> >there is no way to javadoc a method that might throw both an
> >IOException and a FileNotFoundException. Loath FinalParameters.
> 
> Well then the file should not be called sun_checks.xml, it is just
> another user configuration.  The sun coding standard support
> should do exactly what it says on the tin and nothing more.

The sun_checks.xml file is not the Sun coding standards. It is
    really a show of force. It enables every nit-picker in
    Checkstyle so that Checkstyle can strut its stuff. Some of the
    nit-pickers contradict each other. Some are design strictures,
    not coding standards. Some of them are bang opposite of the Sun
    convention.

Coming back to AvoidInlineConditionals :

http://checkstyle.sourceforge.net/config_coding.html#AvoidInlineConditionals

"Rationale: Some developers find inline conditionals hard to read,
    so their company's coding standards forbids them."

The Sun standards actually advocate the use of inline conditionals
to clarify return statements: 

http://java.sun.com/docs/codeconv/html/CodeConventions.doc9.html#570

Tinned Sun code? Jalopy is the answer. My jaw-dropped when I first
ran it. Forgive me my enthusiasm. I'm still enamoured of this
application. And Maven supports Jalopy so well, too!

Checkstyle does check formatting, but it also seeks structural
problems, and Javadoc errors. The name sun_checks.xml might be a
misnomer in any case. Perhaps, better names might be
relaxed_checks.xml and rediculous_checks.xml.

-- 
Alain Javier Guarnieri del Gesu - [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to