Hi Arnaud, Per my off-list email, your latest version of the patch looks fine. Thanks!
Denis On Sat, 2004-05-22 at 13:59, Arnaud Heritier wrote: > Hello Denis, > > I studied your patch and I modified the Javadoc plugin to allow the use of > maven.compile.src.set if you want to test. > > Arnaud > > > -----Message d'origine----- > > De : Arnaud Heritier [mailto:[EMAIL PROTECTED] > > Envoy� : jeudi 20 mai 2004 15:41 > > � : 'Maven Users List'; [EMAIL PROTECTED] > > Objet : RE: javadoc on generated source directories > > > > > > > > > -----Message d'origine----- > > > De : Denis McLaughlin [mailto:[EMAIL PROTECTED] > > > Envoy� : jeudi 20 mai 2004 06:02 > > > � : Maven Users List > > > Objet : RE: javadoc on generated source directories > > > > > > Alrighty, I found an existing issue on Jira regarding the use of > > > maven.compile.src.set with Javadoc: > > > > > > http://jira.codehaus.org/browse/MPJAVADOC-5 > > > > yes > > > > > > > > So I've attached my 1.3 patch to that issue, and added a comment. > > > > thanks > > > > > > > > For what it's worth, I'd be happy to generate a patch against 1.4 or > > > 1.5 (the relevant sections being the same in both, I believe), but I > > > have some questions about the newer plugins. If someone can answer > > > these, I'll poop out a patch against 1.5. > > > > I will try to answer ;-) > > > > > > > > I think moving the fileset generation from the > > > maven-javadoc-plugin:report tag to the check-needed tag is so that the > > > contents of the fileset can be checked: if there's nothing in there, > > > needed is set to false and javadoc will never even be called. Also, the > > > fileset is passed out of the check-needed tag via the sourceSet refid. > > > > All right. > > > > > > > > To support multiple source directories, I can change the check-needed > > > tag so that it iterates across maven.compile.src.set, setting needed to > > > be true if there are files in any of the filesets, and false otherwise. > > > > Seems to be good. > > The problem is to not duplicate entries between pom.build.sourceDirectory > > and maven.compile.src.set > > > > > > > > > > However, I don't think there's any way to preserve the functionality > > > of passing the fileset out via sourceSet: can filesets be added to one > > > another, so that the set of all files in all directories of > > > maven.compile.src.set can be put into one fileset? If not, it means > > > iterating across the directories of maven.compile.src.set twice: once to > > > set the needed value, and again when the filesets are needed in the > > > javadoc tag. Not pretty, but it should work. > > > > You can't have in ant a fileset with several directories. > > We can begin to test if it works. We will optimize it after. > > > > > > > > Can someone let me know if this sounds vaguely correct? If I have a > > > basic understanding of this, I'll generate a patch against the 1.5 > > > javadoc and put it up on jira. > > > > This sounds correct. I'll test your patch as soon as possible. > > > > Arnaud > > > > > > > > Denis > > > > > > On Wed, 2004-05-19 at 05:58, Arnaud Heritier wrote: > > > > I'm working on a release 1.5.1 for the javadoc which will be supplied > > in > > > > RC3. > > > > > > > > If you have a patch, post it on Jira and it will be applied. > > > > > > > > Arnaud > > > > > > > > > > > > > > > > > -----Message d'origine----- > > > > > De : Martin Skopp [mailto:[EMAIL PROTECTED] > > > > > Envoy� : mercredi 19 mai 2004 09:18 > > > > > � : Maven Users List > > > > > Objet : Re: javadoc on generated source directories > > > > > > > > > > On Tue, 2004-05-18 at 07:33, Denis McLaughlin wrote: > > > > > > I had sent the email below asking for some information about > > > modifying > > > > > > the maven javadoc plugin to properly support the > > > maven.compile.src.set. > > > > > > I've generated a patch that seems to do the right thing: it's > > > attached > > > > > > below. Comments quite welcome. > > > > > > > > > > Raise a JIRA issue, I wanna vote for it :-) > > > > > Lets hope that it will be included in RC3, > > > > > > > > > > cu > > > > > -- > > > > > Martin Skopp > > > > > Riege Software International GmbH > > > > > Support: mailto:[EMAIL PROTECTED], Information: http://www.riege.com > > > > > > > > > > This email is intended to be viewed with a nonproportional font. > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > - > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
