ok, I understand now

Actual AbstractMavenReport from reporting-impl doesn't check if the report is 
external or not: it always considers "internal" reports, that is reports done 
with Doxia

I created MSHARED-204 to track the fix in the abstract class, then let every 
external reporting plugins automatically inherit from the behaviour

Regards,

Hervé

Le mercredi 24 août 2011, Benson Margulies a écrit :
> To clarify how all this happened to me today:
> 
> JXR never had a proper 'execute' method, so running JXR as a build
> plugin instead of a reportSet never worked.
> 
> When I added the aggregate goals, I somehow got turned around and made
> the IT use a combination of build plugin and reportSet. I thought I'd
> expropriated that from a javadoc integration test, but I didn't. I
> still can't figure out where I got that from.
> 
> The build execution ran second, and wrote a useless dummy report file.
> 
> In fact, the aggregate goals worked perfectly fine as reports in a
> report set all along, as per Hervé's note about Maven's own use of it.
> 
> So the net result of this is to supply JXR with the missing execute
> method so that it, in fact, works as a build plugin, and to repair the
> doc.
> 
> On Tue, Aug 23, 2011 at 7:40 PM, Barrie Treloar <[email protected]> wrote:
> > On Wed, Aug 24, 2011 at 7:48 AM, Hervé BOUTEMY <[email protected]> 
wrote:
> >> as you reported, reportSets vs executions strategy has never been really
> >> defined.
> >> m-javadoc-p did extensive documentation, with both forms: it's the first
> >> plugin I know that did show the dual forms
> >> But now that everything is clearly documented, I'm convinced that we
> >> should promote reportSets
> >> But that's my opinion: having other input would be helpful
> > 
> > Isn't report sets vs plugin configuration a known area of weakness and
> > one that is on the list to improve somewhere?
> > (Too lazy to google to look it up :)
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to