Great. Works for me now. Thanks for the fast turn around. On Wed, May 30, 2012 at 1:17 PM, Olivier Lamy <[email protected]> wrote: > fixed. > Have a try with 2.5.1-SNAPSHOT > Thanks for the project sample ! it's now part if the plugin it tests. > > 2012/5/30 Andrew Eisenberg <[email protected]>: >> Thanks. Done. >> >> http://jira.codehaus.org/browse/MNG-5291 >> >> On Tue, May 29, 2012 at 11:40 PM, Olivier Lamy <[email protected]> wrote: >>> Oh!! >>> I see the point and apologize >>> >>> Could you create a sample project and attach it to a jira issue, as it >>> I will add an it test with the groovy compiler use case in the project >>> to ensure no regression. >>> >>> >>> 2012/5/30 Andrew Eisenberg <[email protected]>: >>>> I produce the groovy-eclipse-compiler, which is implemented as a >>>> compiler plugin to compile groovy and java code. Up until now, I >>>> haven't had to specify a strict version for which >>>> maven-compiler-plugin to use and this was good because my users have >>>> reasons for using different versions of the maven-compiler-plugin. >>>> But now that maven-compiler-plugin 2.5 requires plexus-compiler-api >>>> 1.9, this means that I will need to release a new version of my plugin >>>> to be compatible with 2.5, and this new version of the >>>> groovy-eclipse-compiler will not be compatible with older versions of >>>> the maven-compiler-plugin. >>>> >>>> On Tue, May 29, 2012 at 3:19 PM, Olivier Lamy <[email protected]> wrote: >>>>> Hi >>>>> >>>>> 2012/5/30 Andrew Eisenberg <[email protected]>: >>>>>> Hi all, >>>>>> >>>>>> It looks like there is a breaking change with plexus-compiler-api 1.9 >>>>>> from earlier versions of the plugin. >>>>>> >>>>>> 1.8.1: >>>>>> CompilerConfiguration.getCustomCompilerArguments() returns LinkedHashMap >>>>>> >>>>>> 1.9: >>>>>> CompilerConfiguration.getCustomCompilerArguments() returns Map<String, >>>>>> String> >>>>> >>>>> Yup that's why the last release was 1.9 and not 1.8.2 >>>>> >>>>>> >>>>>> This means that a plugins compiled against one version will not work >>>>>> against the other (java.lang.NoSuchMethodError is thrown). Is this >>>>>> right? Am I missing something or must there be a strict dependency on >>>>>> plexus-compiler-api (and hence the maven-compiler-plugin)? >>>>> >>>>> AFAIK plugins comes with defined dependencies. (for sure you can >>>>> override manually in poms and in this case m-c-p won't won't work with >>>>> p-c 1.9) >>>>> What is your use case ? >>>>> >>>>>> >>>>>> thanks, >>>>>> --a >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Olivier Lamy >>>>> Talend: http://coders.talend.com >>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> >>> >>> -- >>> Olivier Lamy >>> Talend: http://coders.talend.com >>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
