Do you mean a patch to the documentation online? On Tue, Jul 3, 2012 at 7:00 PM, Benson Margulies <[email protected]>wrote:
> You're welcome. Please feel free to submit a patch with a better > explanation of this in the doc. > > On Tue, Jul 3, 2012 at 6:55 PM, Jason Rutherglen > <[email protected]> wrote: > > I found the issue, the exclude needs to look like this, two asterisks at > > the end. Thanks for your help. > > > > <exclude>org.apache.solr.**</exclude> > > > > On Tue, Jul 3, 2012 at 5:05 PM, Jason Rutherglen < > [email protected] > >> wrote: > > > >> Here's where the source for Maven Shade 1.7.1 was obtained: > >> > >> > http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plugin-1.7.1 > >> > >> Also not sure how to view the return type inside an if statement using > >> Eclipse. > >> > >> > >> On Tue, Jul 3, 2012 at 2:52 PM, Jason Rutherglen < > >> [email protected]> wrote: > >> > >>> This is what's in the pom.xml so hopefully it's trying to use this, > which > >>> matches the source version being debugged. > >>> > >>> > >>> <groupId>org.apache.maven.plugins</groupId> > >>> <artifactId>maven-shade-plugin</artifactId> > >>> <version>1.7.1</version> > >>> > >>> > >>> On Tue, Jul 3, 2012 at 2:32 PM, Benson Margulies < > [email protected]>wrote: > >>> > >>>> What version of Shade are you trying to use? > >>>> > >>>> On Tue, Jul 3, 2012 at 2:26 PM, Jason Rutherglen > >>>> <[email protected]> wrote: > >>>> > Debugged into SelectorUtils, it seems to be working correctly. I > >>>> > downloaded 1.5.5, step through that source. The matchPath methods > >>>> returns > >>>> > false, however the if statement in isExcluded evaluates to true. > Must > >>>> be > >>>> > looking at the wrong code? > >>>> > > >>>> > On Tue, Jul 3, 2012 at 11:46 AM, Jason Rutherglen < > >>>> > [email protected]> wrote: > >>>> > > >>>> >> I ran this through a debugger, this line is not behaving as > expected, > >>>> >> where for example 'java/lang/ThreadGroup' matches > 'org/apache/solr/*' > >>>> >> > >>>> >> SimpleRelocator.isExcluded: > >>>> >> > >>>> >> if ( SelectorUtils.matchPath( exclude, path, true ) ) > >>>> >> > >>>> >> > >>>> >> On Tue, Jul 3, 2012 at 11:39 AM, Benson Margulies < > >>>> [email protected]>wrote: > >>>> >> > >>>> >>> On Tue, Jul 3, 2012 at 11:12 AM, Jason Rutherglen > >>>> >>> <[email protected]> wrote: > >>>> >>> > <relocation> > >>>> >>> > <!-- <pattern>*/*</pattern> --> > >>>> >>> > > >>>> >>> <shadedPattern>com.custom.solr.</shadedPattern> > >>>> >>> > <excludes> > >>>> >>> > > <exclude>org.apache.solr</exclude> > >>>> >>> > > >>>> <exclude>org.apache.lucene</exclude> > >>>> >>> > </excludes> > >>>> >>> > >>>> >>> Have you tried adding * or .* to the end of the exclude patterns? > >>>> >>> > >>>> >>> > --------------------------------------------------------------------- > >>>> >>> To unsubscribe, e-mail: [email protected] > >>>> >>> For additional commands, e-mail: [email protected] > >>>> >>> > >>>> >>> > >>>> >> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> > >>> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
