I then suggest to remove the 'until-java11' profile altogether and maybe use Maven Enforcer in order to make sure that the project is built at least with JDK 11 (see commit [1]).
I also found out how to move the Surefire config back into the root POM (see commit [2]). I must have been blind before not to see that the plugin configurations should to into the <pluginManagement> sections of each profile instead of declaring the plugins as active in the root POM. Now there is no more duplication and all modules actually having tests get the correct configuration automatically. If you were happy with the previous version already, I am expecting a major endorphin flash now. ;-) [1] https://github.com/kriegaex/kryo/commit/d6545ce323264f29e054bf3190fd03b7da91b8cc [2] https://github.com/kriegaex/kryo/commit/40d5c5ad3f2ea74f28b3f91e9555a2a335e68b2b -- Alexander Kriegisch https://scrum-master.de Julia Boes schrieb am 03.09.2020 22:11 (GMT +07:00): >> So what I suggest is to not just run a single test on JDK 14 but to run >> all tests, just like you compile all tests. > > I had originally expected more errors when compiling/running with JDK 14 but > that didn't turn out to be the case - good! > > I adopted your last commit (move surefire configuration to root pom and > streamline), which is a neat solution. It would be great to do something > similar for the compiler plugin but given that I've already tried my luck at > that I'm happy with this version. > >> By the way, in the root POM is another profile 'until-java11' with >> activation condition <jdk>[1.5,11)</jdk>, excluding certain Java 11 >> tests. I tried to run a build on JDK 8 or JDK 9 with Kryo master, but it >> does not even compile because it uses Java 10+ API calls. So maybe >> Kryo's build configuration is outdated already. But that's just another >> strange thing about that project. I will just assume that anything below >> JDK 11 is irrelevant to you, even though you have created a Java 8+ >> profile. Or does your own real project fork off of another Kryo branch >> which is not the master? > > That's right, the JDK 8+ profile was left over from when I thought kryo was > built with JDK 8. That's not the case, it's built with JDK 11. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
