There didn't seem to be a good intermediate point. Maven wanted things organized differently, and I didn't know Maven well enough to argue with it.
Switching from private binaries to Maven packages was a driving force behind the cut-over, and the need to move from jlec to jflex forced the one significant code change. The "insignificant" ones in Javadoc were an attempt to get a Maven build with no errors before I found the control for turning off doclint. I could back them out but that doesn't seem a good use of resource at this point. There really isn't that much actual code change. Most of it is moving things into different subdirectories. It's a one time cost. There's really less needing review than may appear. If someone wants to volunteer to take my changeset as the final goal and deliver it incrementally, I have no objection. I'm sure someone who knew Maven better could have done this more incrementally. But I'm what was available, and this is what I could do. And it's actually pretty clean. I think. -- /_ Joe Kesselman (he/him/his) -/ _) My Alexa skill for New Music/New Sounds fans: / https://www.amazon.com/dp/B09WJ3H657/ () Plaintext Ribbon Campaign /\ Stamp out HTML mail! ________________________________ From: Greg Chabala <greg.chab...@gmail.com> Sent: Saturday, October 14, 2023 1:50:16 PM To: Maven Users List <users@maven.apache.org> Subject: Re: Feedback sought That's certainly an ambitious changeset, but it takes courage to do great work. I'd generally suggest trying to make smaller steps so it's easier on reviewers. For instance: - Could you make a basic Maven build that delegated most of the work to Ant with maven-antrun-plugin? - If so, then you could have separate follow up steps for moving code into the standard Maven layout, and converting from libraries in source to Maven retrieved versions. - Could you convert a smaller artifact first, like the samples directory? As far as specific advice on your current PR: - I'd recommend taking this opportunity to remove IDE droppings from source control entirely. .classpath, .project, .settings/* are all Eclipse specific and will be regenerated when the project is imported, if needed. They are needless noise in source control and IntelliJ IDEA users don't care about them at all. - Everything in META-INF will be generated by Maven, so none of that should be in source control either.
