A couple comments... take them or not, entirely your choice: 1. The properties at the bottom -- any reason you aren't just configuring maven-compiler-plugin instead?
2. Its a bit unfortunate the maven-jar-plugin doesn't support the includes/excludes you require, and so you have to use antrun instead. I found MJAR-30 so its been posted as an issue, but it seems like no one has offered any patches for it. This seems like an old issue, with a number of people being interested in it, so I'm not quite sure why it hasn't been addressed -- the lack of a patch seems to be a failure in the community/process. 3. Many of your plugins do not declare any scope, meaning default "compile" scope. I prefer to declare all scopes rather than assuming default. So I'd add <scope>compile</scope> to those missing a scope. 4. Some but not all of your plugins have versions declared. I like to see versions for everything. 5. I like <dependencyManagement> and <pluginManagement>. You don't have to use them (and you're obviously not using them right now), but I like them. The areas I'm primarily concerned with seem to be handled in this version, so Bravo! These are minor nits. Wayne On 8/27/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > Hi all > > The poms for commons logging has taken some beating on this list over > the years. The reason for that has been the dependencies section. > Previous poms of commons-logging was created for Maven 1. These were > then converted into Maven 2 poms with various degree of success. In > particular the scope wasn't set properly. > > We are now preparing the next release of commons-logging (version 1.1.1) > which will be built with Maven 2. That means that the pom that ends up > in the Maven 2 repository will be the same one that we have created. > > To make sure that we have covered all bases this time we invite you, the > community, to help us get it right. The current pom.xml is available for > your viewing in our subversion repository: > > > https://svn.apache.org/viewvc/commons/proper/logging/trunk/pom.xml?revision=568979&view=markup > > Please post any comments you have on the pom to this list, and I will > bring the over to the commons community. > > -- > Dennis Lundberg > Apache Commons committer and PMC member > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
