A good point there though. Instead of every single component having to
deal with PRETTY_HTML when rendering, the extensionsFilter (or another
filter) could (& should?) take care of prettying up the output. Much
more elegant solution and less coding for everybody, no?
Kalle
________________________________
From: Randahl Fink Isaksen [mailto:[EMAIL PROTECTED]
Sent: Wednesday, June 01, 2005 8:30 AM
To: MyFaces Discussion
Subject: Re: org.apache.myfaces.PRETTY_HTML
I see your point, but I do not think this feature should be
removed, rather, it should be fixed so it works on all platforms.
Of course we can all write our own servlet filter to do the
pretty printing - but why not make pretty printing a built in feature
for everyone to share? Pretty printing makes it easier for everyone to
debug the output with no need to use special software. Relying on a
pretty printing plugin for FireFox is not going to work for those
developers who deliver and debug solutions which are targeted for, say,
Internet Explorer.
I noticed Daniel says it works for him - could it be a character
encoding problem? I generate UTF-8 and read the output using FireFox on
Windows XP.
Any observations?
Randahl
t have an impact on performance...
Bruno
2005/6/1, Sean Schofield <[EMAIL PROTECTED]>:
I can confirm that it doesn't work for me
either. I found a sweet
plugin for Firefox though that basically does
this for you. (NOTE:
its a plugin not the default view source.) It
works pretty nice on
the tree2 examples (which are *definitely* not
pretty with all the
nested tables.) Too bad I didn't have it while
debugging the
renderer!
We may want to consider removing this feature if
it doesn't
effectively do anything. I think making it work
would be a lot of
work ;-)
sean
On 6/1/05, Daniel Zwink <[EMAIL PROTECTED]> wrote:
> Hi,
>
> uh - shame on me and thanks to b0nyb0y! I've
only seen the JavaScript part
> and didn't realise that the HTML-part is in
one single line.
>
> > Have anyone else successfully configured
myfaces to
> > generate PRETTY_HTML output which shows up
nicely in
> > a browser's "View Source" tool?
>
> Me ;-). On my system (Windows XP, Tomcat
5.5.9, MyFaces 1.0.9 M9) the
> generated html is relatively pretty (e.g.
there are line breaks between
> tags) with context parameter
"org.apache.myfaces.PRETTY_HTML" set to true
> (in web.xml).
>
>
> Daniel
>
>
