Hi Sean, I´ve saw that if I don´t make it from root my path structure above the project is used in the patches, which is the problem right?
I would like to create that patch on project root but svn does not create one (only an empty file). I´ve tried tortoise and subclipse without success. Mathias > -----Original Message----- > From: Sean Schofield [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 05, 2005 4:21 PM > To: MyFaces Discussion > Subject: Re: MYFACES-228: preserveDataModel=true and > x:dataTable fixed? > > > Mathias, > > So far this looks good. I like that you've found a way to workaround > treating UIData, etc. in a special manner when saving and restoring > states. > > I'm having trouble with the Tomahawk patch. SVN is complaining about > HtmlDataTablePhaseListener and HtmlDataTableHack. Are you removing > these classes? If not, can you generate a new patch for just those > two? (Generate from the project root please.) > > sean > > > On 7/5/05, Broekelmann, Mathias <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I would like to solve this issue. I´ve reimplemented the > UIData and derived DataTable components for this issue. > However it will take some time to test all usecases. > > > > This is what I´ve done so far: > > > > - reduce the error phrone and complex code in > saveDescendantComponentStates and restoreDescendantComponentStates. > > > > - using StateHolder.saveState and restoreState methods for > nested components. > > > > - no special handling for nested UIData components needed any more > > > > - get rid of phase listener for datatable > > > > As far as I´ve tested my implementation it works nicely. I > will do some more tests today in our application which > heavily uses the UIData components to see if it works. > > > > If anyone is interessted to check if my code is running in > your application you may apply the patch which is attached. > > > > Mathias > > > > > -----Original Message----- > > > From: Sean Schofield [mailto:[EMAIL PROTECTED] > > > Sent: Monday, July 04, 2005 5:34 PM > > > To: MyFaces Discussion; Mike Kienenberger > > > Subject: Re: MYFACES-228: preserveDataModel=true and > > > x:dataTable fixed? > > > > > > > > > The bug is marked "in progress", so no, it has not been > fixed yet. At > > > the moment it is assigned to me but I am looking for volunteers to > > > take a detailed look at this one. I'm a little tied up > with the reorg > > > so any help would be appreciated. > > > > > > sean > > > > > > On 7/1/05, Mike Kienenberger <[EMAIL PROTECTED]> wrote: > > > > Is preserveDataModel patch mentioned in > > > > http://issues.apache.org/jira/browse/MYFACES-228 considered > > > working as > > > > of tag BEFORE_SVN_REORG (2005-06-25-ish)? > > > > > > > > I have a x:dataTable with h:inputText elements that don't > > > update if I > > > > specify preserveDataModel="true", but dataTable does update > > > my data if > > > > I don't include that attribute. > > > > > > > > I'm not using sorting, but I am using the standard "car example" > > > > x:dataScrollers. However, removing the dataScrollers > > > doesn't seem to > > > > change the behavior. > > > > > > > > My value binding for dataTable is > > > > value="#{viewSecRolePage.secRoleList}" and the following > > > methods exist > > > > on the class, but the setters are never triggered. > > > > > > > > public List getSecRoleList() { /* [...] */ } > > > > > > > > public void setSecRoleList(List preservedList) > > > > { > > > > // breakpoints set in here are never hit. > > > > } > > > > > > > > public void setSecRoleList(Object preservedListObject) > > > > { > > > > // breakpoints set in here are never hit. > > > > } > > > > > > > > Thanks, > > > > > > > > -Mike > > > > > > > > > > > > > >
