I looked into the merger code and found a possible issue.  I haven't been
able to reproduce the test failure you're getting by setting my locale to
en_IN, but I have a sneaking suspicion that FormatUtils might be the
culprit here when it's formatting the value for TasksDuration in the target
DTO.  Can you please change line 86 in FormatUtils to use
Locale.getDefault() instead of Locale.US and rerun the tests?

On Fri, Sep 16, 2016 at 1:12 PM Tijo Thomas <tijopara...@gmail.com> wrote:

> Hi Jeff,
>
> Yes,  I took a fresh clone from git hub .  I cleaned my maven repo as well
> before building .
>
>  Attached StatusMerger.java and ProcessorStatusSnapshotDTO.java
>
> All,
>
> It will be great if others also check if it is happening when u build. I
> am worried whether I am doing some thing really stupid.
>
> Thanks & Regards
>
> Tijo Thomas
>
> On 16-Sep-2016 7:47 pm, "Jeff" <jtsw...@gmail.com> wrote:
>
>> Thank you for the information.  Did you try running the tests on a fresh
>> clone of the github repo?
>>
>> Could you please link me to or include the contents of StatusMerger.java
>> and ProcessorStatusSnapshotDTO.java?
>>
>> On Fri, Sep 16, 2016 at 4:17 AM Tijo Thomas <tijopara...@gmail.com>
>> wrote:
>>
>>>
>>> Output when I ran through IDE,
>>>
>>>
>>> Condition not satisfied:
>>>
>>> returnedJson == expectedJson
>>> |            |  |
>>> |            |
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:00:00.000","activeThreadCount":0}
>>> |            false
>>> |            1 difference (99% similarity)
>>> |
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:(3)0:00.000","activeThreadCount":0}
>>> |
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:(0)0:00.000","activeThreadCount":0}
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:30:00.000","activeThreadCount":0}
>>>
>>> Expected
>>> :{"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:00:00.000","activeThreadCount":0}
>>>
>>> Actual
>>> :{"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:30:00.000","activeThreadCount":0}
>>>
>>>
>>> Taskduration is showing 30 min different when compared to expected and
>>> actuals.
>>>
>>>     at
>>> org.apache.nifi.cluster.manager.PermissionBasedStatusMergerSpec.Merge
>>> ProcessorStatusSnapshotDTO(PermissionBasedStatusMergerSpec.groovy:257)
>>>
>>>
>>>
>>> Condition not satisfied:
>>>
>>> returnedJson == expectedJson
>>> |            |  |
>>> |            |
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:00:00.000","activeThreadCount":0}
>>> |            false
>>> |            1 difference (99% similarity)
>>> |
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:(3)0:00.000","activeThreadCount":0}
>>> |
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:(0)0:00.000","activeThreadCount":0}
>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:30:00.000","activeThreadCount":0}
>>>
>>> Expected
>>> :{"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:00:00.000","activeThreadCount":0}
>>>
>>> Actual
>>> :{"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:30:00.000","activeThreadCount":0}
>>>
>>>
>>> mvn --version
>>>
>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>>> 2015-11-10T22:11:47+05:30)
>>> Maven home: /home/tijo/apache-maven-3.3.9
>>> Java version: 1.8.0_91, vendor: Oracle Corporation
>>> Java home: /home/tijo/jdk1.8.0_91/jre
>>> Default locale: en_IN, platform encoding: UTF-8
>>> OS name: "linux", version: "3.13.0-95-generic", arch: "amd64", family:
>>> "unix"
>>>
>>>
>>> Tijo
>>>
>>>
>>>
>>> On Thu, Sep 15, 2016 at 8:07 PM, Jeff <jtsw...@gmail.com> wrote:
>>>
>>>> Hello,
>>>>
>>>> Could you try building a fresh clone of the NIFI repo?  What is your
>>>> dev environment?  What versions of java and maven are you running?
>>>>
>>>> Does PermissionBasedStatusMergerSpec work when you run it directly via
>>>> maven and/or an IDE?
>>>>
>>>> On Wed, Sep 14, 2016 at 2:37 PM Tijo Thomas <tijopara...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Jeff,
>>>>>
>>>>> I tried replacing the mvn repo and  did  mvn clean package.
>>>>>
>>>>> I am still getting this error.
>>>>>
>>>>> I am sorry I am not getting any clue why it is failing.
>>>>>
>>>>> Can you check again.
>>>>>
>>>>> Tijo
>>>>>
>>>>> On Wed, Sep 14, 2016 at 9:27 PM, Jeff <jtsw...@gmail.com> wrote:
>>>>>
>>>>>> Ok, sounds good!  Please let us know!
>>>>>>
>>>>>> On Wed, Sep 14, 2016 at 12:04 AM Tijo Thomas <tijopara...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Sorry to reply  late. I was on vacation for last 4 days.
>>>>>>>
>>>>>>> I have not modified any files.
>>>>>>>
>>>>>>> I think there is some problem with my repo.  I will make a new repo
>>>>>>> and try again.  Still the problem  exist I will post it again in the 
>>>>>>> group.
>>>>>>>
>>>>>>> Thank you very much for your support.
>>>>>>>
>>>>>>> Tijo
>>>>>>>
>>>>>>> On 10-Sep-2016 6:44 pm, "Jeff" <jtsw...@gmail.com> wrote:
>>>>>>>
>>>>>>>> Tijo,
>>>>>>>>
>>>>>>>> Have you modified ProcessorStatusSnapshotDTO.java or
>>>>>>>> PermissionBasedStatusMergerSpec.groovy?
>>>>>>>>
>>>>>>>> On Sat, Sep 10, 2016 at 7:48 AM Tijo Thomas <tijopara...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Jeff
>>>>>>>>>
>>>>>>>>> I recently  rebase  from master.
>>>>>>>>> Then I cloned again and ran mvn  package
>>>>>>>>>
>>>>>>>>> Tijo
>>>>>>>>>
>>>>>>>>> On 09-Sep-2016 9:12 pm, "Jeff" <jtsw...@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Tijo,
>>>>>>>>>>
>>>>>>>>>> I just ran this test on master and it's passing for me.  Can you
>>>>>>>>>> provide some details about the branch you're on when running the 
>>>>>>>>>> tests?  I
>>>>>>>>>> see that tasksDuration is 00:30:00.000 when it's expecting 
>>>>>>>>>> 00:00:00.000,
>>>>>>>>>> and that's why the JSON isn't matching.
>>>>>>>>>>
>>>>>>>>>> On Thu, Sep 8, 2016 at 4:58 PM Tijo Thomas <tijopara...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi
>>>>>>>>>>> Nifi test case is failing (PermissionBasedStatusMergerSpec) .
>>>>>>>>>>> This is written in Grovy .. not comfortable with Groovy .
>>>>>>>>>>>
>>>>>>>>>>> Running
>>>>>>>>>>> org.apache.nifi.cluster.manager.PermissionBasedStatusMergerSpec
>>>>>>>>>>> Tests run: 20, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
>>>>>>>>>>> 0.922 sec <<< FAILURE! - in
>>>>>>>>>>> org.apache.nifi.cluster.manager.PermissionBasedStatusMergerSpec
>>>>>>>>>>> Merge
>>>>>>>>>>> ProcessorStatusSnapshotDTO[0](org.apache.nifi.cluster.manager.PermissionBasedStatusMergerSpec)
>>>>>>>>>>> Time elapsed: 0.144 sec  <<< FAILURE!
>>>>>>>>>>> org.spockframework.runtime.SpockComparisonFailure: Condition not
>>>>>>>>>>> satisfied:
>>>>>>>>>>>
>>>>>>>>>>> returnedJson == expectedJson
>>>>>>>>>>> |            |  |
>>>>>>>>>>> |            |
>>>>>>>>>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>>>>>>>>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>>>>>>>>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>>>>>>>>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:00:00.000","activeThreadCount":0}
>>>>>>>>>>> |            false
>>>>>>>>>>> |            1 difference (99% similarity)
>>>>>>>>>>> |
>>>>>>>>>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>>>>>>>>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>>>>>>>>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>>>>>>>>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:(3)0:00.000","activeThreadCount":0}
>>>>>>>>>>> |
>>>>>>>>>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>>>>>>>>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>>>>>>>>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>>>>>>>>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:(0)0:00.000","activeThreadCount":0}
>>>>>>>>>>> {"id":"hidden","groupId":"hidden","name":"hidden","type":"hidden","bytesRead":0,"bytesWritten":0,"read":"0
>>>>>>>>>>> bytes","written":"0 bytes","flowFilesIn":0,"bytesIn":0,"input":"0 (0
>>>>>>>>>>> bytes)","flowFilesOut":0,"bytesOut":0,"output":"0 (0
>>>>>>>>>>> bytes)","taskCount":0,"tasksDurationNanos":0,"tasks":"0","tasksDuration":"00:30:00.000","activeThreadCount":0}
>>>>>>>>>>>
>>>>>>>>>>>     at
>>>>>>>>>>> org.apache.nifi.cluster.manager.PermissionBasedStatusMergerSpec.Merge
>>>>>>>>>>> ProcessorStatusSnapshotDTO(PermissionBasedStatusMergerSpec.groovy:257)
>>>>>>>>>>>
>>>>>>>>>>> Merge
>>>>>>>>>>> ProcessorStatusSnapshotDTO[1](org.apache.nifi.cluster.manager.PermissionBasedStatusMergerSpec)
>>>>>>>>>>> Time elapsed: 0.01 sec  <<< FAILURE!
>>>>>>>>>>> org.spockframework.runtime.SpockComparisonFailure: Condition not
>>>>>>>>>>> satisfied:
>>>>>>>>>>>
>>>>>>>>>>> Tijo
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>
>>>

Reply via email to