Ok. Is there any sort of formal process to get a review started? Thanks,
Mike On Tue, Jun 27, 2017 at 2:40 PM, Pierre Villard <[email protected] > wrote: > If you have someone reviewing your work and if you are quickly taking into > accounts the remarks/comments, it should not be long. > It's really up to someone volunteering for the review process. That's also > why we invite people to review/test PRs from other contributors: it shows > the interest of the community and speed up the review process. > > Thanks! > > 2017-06-27 19:49 GMT+02:00 Mike Thomsen <[email protected]>: > >> I pushed an update to 4124 based on Brian's suggestion on GitHub. It runs >> just fine for me where I'm working. >> >> I'd like to get these changes merged because we don't want to have to >> maintain a separate build of the nifi-mongo bundle. How often are pull >> requests evaluated for inclusion into master? >> >> Thanks, >> >> Mike >> >> On Tue, Jun 27, 2017 at 6:49 AM, Pierre Villard < >> [email protected]> wrote: >> >>> Hi Mike, thanks for the contributions! >>> >>> Don't bother about AppVeyor builds, for now it's broken. We are only >>> looking at Travis builds, and even for this build, we see intermittent >>> failures. Personally I look at the travis details and check that at least >>> one of language-dependent build is OK (and that the others are not failing >>> because of language issues). >>> >>> Thanks >>> >>> 2017-06-27 12:43 GMT+02:00 Mike Thomsen <[email protected]>: >>> >>>> The Travis CI tests passed for mine, but the AppVeyer build failed >>>> because it didn't like some other NiFi module. PRs: >>>> >>>> https://github.com/apache/nifi/pull/1948 >>>> >>>> https://github.com/apache/nifi/pull/1945 >>>> >>>> One is a PR to make GetMongo better able to handle very large queries >>>> (ex. for bulk ingestion like pulling 10s of millions of records) and the >>>> the other PR is one that adds a new form of PutMongo that uses the Record >>>> API. >>>> >>>> (I've been slowly cleaning up PutHBaseRecord, but haven't had time to >>>> make sure it handles all of the serialization options that PutHBaseJSON >>>> accepts.) >>>> >>>> Thanks, >>>> >>>> Mike >>>> >>> >>> >> >
