Hi Mark, Thank you for take some time in the issue. Regarding your questions:
* *What does it mean exactly to have an Avro schema with an "array" type that has a value?* -> A default value I mean. ** What should be the value of this field if it's not specified?* *A single-element array with the value of 0? * -> Do you mean without default? It fails with the error: org.apache.avro.AvroRuntimeException: Field listOfInt type:ARRAY pos:0 not set and has no default value I agree that the default value is not the best example (I took from a real scenario), but Avro does not complain and default it to an empty array. I also added a reproducible scenario with the default value to [0] and also it fails. This issue prevent using ConvertRecord because it is not possible to create a RecordSchema from that Avro schema. I believe, in this case mimic Avro. If the type is an array and the default value is not an array, default to an empty array. Thanks a lot, please let me know if you need something else, I will be glad to help you. I'm interested in fix of this issue. Juan On Tue, 27 Feb 2018 at 10:56 Mark Payne <[email protected]> wrote: > Juan, > > So the scenario that you laid out in the NIFI-4893 is not one that I've > personally > encountered. What does it mean exactly to have an Avro schema with an > "array" type > that has a value? In the example that you laid out, the field has: > > "type": {"type": "array", "items": "int" }, "default": 0 > > > In this case, what should be the value of this field if it's not > specified? A single-element array with the value of 0? > From looking at the PR that was submitted, it appears to set the > defaultValue to a new (empty) ArrayList. > I would think that maybe it should set defaultValue to > > new Integer[] {0}; > > But I am not certain of the semantics here. > > Thanks > -Mark > > > On Feb 27, 2018, at 7:30 AM, Juan Pablo Gardella < > [email protected]> wrote: > > Hello team, > > I could not fix the issue. I did a patch but it's solves the issue, but I > believe is not the correct solution. Anyone that knows Record Framework can > help me on that? > > Thanks in advance, > Juan > > On Mon, 19 Feb 2018 at 22:33 Juan Pablo Gardella < > [email protected]> wrote: > >> I saw an issue in a test :(. I will continue looking into current >> approach. >> >> On Mon, 19 Feb 2018 at 22:23 Juan Pablo Gardella < >> [email protected]> wrote: >> >>> Hello team, >>> >>> I filed an issue at https://issues.apache.org/jira/browse/NIFI-4893. I >>> discovered using a complex Avro schema. I've isolated the issue and also >>> did a patch. At least, this solve the issue but actually I don't know well >>> the implications on that solution. >>> >>> Please let me know what do you think. I have another issue related to >>> Avro and Record, I will file the issue tomorrow. >>> >>> Thanks, >>> Juan >>> >> >
