Hi Bryan, Thanks, I completely missed that! It also makes more sense why some of the properties use dot notation over dash. Definitely something that there should be tests around to make sure it isn't accidentally removed.
Thanks, Jason On Tue, Jul 7, 2020 at 9:48 AM Bryan Bende <[email protected]> wrote: > Hi Jason, > > It is a bit confusing, but in the createConsumerPool there is a line: > > KafkaProcessorUtils.buildCommonKafkaProperties(context, > ConsumerConfig.class, props); > > That ends up looping through all the properties of the processor and > checking if their name matches any of the names in ConsumerConfig, and if > so it adds the key/value to the config map. > > So since the property is named "max.poll.records", that is the same name > in ConsumerConfig. > > Thanks, > > Bryan > > On Tue, Jul 7, 2020 at 9:32 AM Jason Iannone <[email protected]> wrote: > >> Hi all, >> >> I have been digging through the ConsumeKafka_2_0 (and record) code and >> noticed that the PropertyDescriptor for MAX_POLL_RECORDS isn't connected to >> anything. Is this intentional, and a "deprecated field" or am I missing >> something? >> >> Thanks, >> Jason >> >
