On 08/05/2014 02:54 PM, Robbie Gemmell wrote:
Part of the reason it is the way it is currently is because I tied creation
of the tar.gz assembly files to the 'package' phase so that the systests
could immediately use the broker tar.gz release in the integration-tests
phase (they fire up an external broker using it via the startup scripts).
Traditionally you might be more likely to build the assemblies later in the
cycle, or only when using a release profile, or maybe explicitly using "mvn
assembly:single". The examples havent been built at the point the client is
packaged currently, because they actually depend on the client and so only
get built afterwards.
Adding a tar.gz file containing just the example jar would be easy. To
include the examples and client jars in the same assembly we would likely
need to add a further 'packaging' module to gather everything up together,
or have the examples module tar.gz duplicate the client libs.
An alternative could be to bundle the example src (only) in the client
releases, with their build pom.
I think that would be my preference, i.e. having the example source in
the client artefact itself along with a brief description of how to
build and run them.
The instructions can then say how to build
and run them. As alternative to that the examples jar would still be
available via maven central (unless we alter the poms not to publish the
jar).
Robbie
On 5 August 2014 14:21, Justin Ross <[email protected]> wrote:
That's fine by me, though in general I tend to think it's better to have
fewer bundles and keep the examples with the client libraries they
correspond to.
A separate issue: the examples artefact is a jar, not a tar.gz like the
other artefacts. That's certainly not a big deal, just a little
incongruous.
Justin
On Tue, Aug 5, 2014 at 8:22 AM, Keith W <[email protected]> wrote:
On 4 August 2014 11:31, Gordon Sim <[email protected]> wrote:
On 07/31/2014 02:01 PM, Keith W wrote:
It occurs to me that as the Java Client Examples are now a separate
artefact in its own right (rather than examples being part of the Java
Client), I think it would be a good idea if this artefact is
distributed too. It is the artefact generated by
java/client/example/pom.xml. I expect this will be useful for users
and I for one always use drain/spout from the examples for my kick the
tyres type tests.
I agree, having examples or 'test clients' of some kind easily
accessible
and guaranteed to work with a given release is important.
Is this separate artefact only the 0-10 and earlier compatible
examples?
These examples are suitable for 0-8..0-10.
Is there a separate one for the 1.0 client?
qpid-ampq-1-0-client does have its own examples (./examples), but
there is no maven pom.xml, so there is no distributable artefact.
It would be easy to add a pom.xml. I'm happy to volunteer to do this.
Thoughts?
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
