I increased the timeout from 5 to 100 and the test which now takes 110 seconds
instead of 10 seconds is still failing. After re-checking, the error message is
actually the same on each failure. I think there is an issue here.
My patch:
diff --git a/tests/system_tests_drain_support.py
b/tests/system_tests_drain_support.py
index e4bd2bc..9a4a86f 100644
--- a/tests/system_tests_drain_support.py
+++ b/tests/system_tests_drain_support.py
@@ -46,7 +46,7 @@ class DrainMessagesHandler(MessagingHandler):
self.conn.close()
def on_start(self, event):
- self.timer = event.reactor.schedule(5, Timeout(self))
+ self.timer = event.reactor.schedule(100, Timeout(self))
self.conn = event.container.connect(self.address)
# Create a sender and a receiver. They are both listening on the same
address
==================
Error
===================
13: FAIL: test_www_drain_support_all_messages
(system_tests_link_routes.LinkRouteTest)
13: ----------------------------------------------------------------------
13: Traceback (most recent call last):
13: File "/qpid-dispatch-0.7.0/tests/system_tests_link_routes.py", line 489,
in test_www_drain_support_all_messages
13: self.assertEqual(None, drain_support.error)
13: AssertionError: None != 'Timeout Expired: sent: 10 rcvd: 8'
13:
13: ----------------------------------------------------------------------
13: Ran 15 tests in 109.933s
13:
13: FAILED (failures=1)
1/1 Test #13: system_tests_link_routes .........***Failed 110.16 sec
Regards,
Adel
________________________________
From: Adel Boutros <[email protected]>
Sent: Tuesday, February 28, 2017 2:47:16 PM
To: [email protected]
Subject: [Qpid Dispatch - 0.7.0] Random failure on unit test
"system_tests_link_routes" on Linux
Hello,
I noticed a random issue with the Dispatch Router 0.7.0 which has a random
failure in the test "system_tests_link_routes".
I launch the same test 10 times, it fails randomly (Failure occurs at the 4th
or 5th run) but always with a similar error. It seems the timeout of 5
milliseconds is not enough especially on slow machines.
I had submitted a patch for a similar task
(https://issues.apache.org/jira/browse/DISPATCH-627)
Can you please confirm?
Regards,
Adel
13: ======================================================================
13: FAIL: test_www_drain_support_all_messages
(system_tests_link_routes.LinkRouteTest)
13: ----------------------------------------------------------------------
13: Traceback (most recent call last):
13: File "/qpid-dispatch-0.7.0/tests/system_tests_link_routes.py", line 489,
in test_www_drain_support_all_messages
13: self.assertEqual(None, drain_support.error)
13: AssertionError: None != 'Timeout Expired: sent: 10 rcvd: 8'
