I concur with the reasoned replies to my negative vote and switch my vote to +1.
I also note that the valgrind error goes away if I remove the pkcs11-provider package. To me, this implies that if there is a leak, it is not in Proton. And as Andrew points out, the “leak” is small in size and its life cycle does not materially differ from proper cleanup. Tested the following builds on Fedora 41: - gcc - clang - libuv - epoll - threaderciser - asan - tsan - valgrind - helgrind Cliff On Fri, Nov 22, 2024 at 11:47 AM Andrew Stitcher <astitc...@redhat.com> wrote: > I've spent a bit of time looking at this and I think this is the result of > the new provider code in OpenSSL. It is still quite new, so very likely has > some issues like this. > > So: > * I don't think it's a regression in proton > * The leak is tiny (only 32 bytes) over a full program run. > * Arguably it's not even a real leak as it's intended to be allocated at > program init and freed at program exit anyway (which is functionally the > same as just exiting the program!) > > So I'd be happy to suppress this warning until openssl fixes it, and I > don't think we need to respin for this, just release note. > > Andrew > > On Thu, Nov 21, 2024 at 10:10 AM Cliff Jansen <cliffjan...@gmail.com> > wrote: > > > -1 > > > > I started by upgrading my test machine to fedora 41 from fedora 40. > Default > > build and test now fails with a new valgrind error in OpenSSL > > initialization. > > > > I get the same error with Proton 0.39, so presumably the error is the > > result of a newer version of OpenSSL or valgrind and not a regression in > > Proton code. > > > > Regardless, I would like to request a chance to investigate if the leak > is > > real or a new valgrind suppression is in order. > > > > Sorry for the unexpected pot hole. > > > > Cliff > > > > On Wed, Nov 20, 2024 at 10:13 AM Robbie Gemmell < > robbie.gemm...@gmail.com> > > wrote: > > > > > Hi folks, > > > > > > I have put together a first spin for a Qpid Proton 0.40.0 release, > > > please give it a test out and vote accordingly. > > > > > > The files can be grabbed from: > > > https://dist.apache.org/repos/dist/dev/qpid/proton/0.40.0-rc1/ > > > > > > The JIRAs assigned are: > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720&version=12353130 > > > > > > It is tagged as 0.40.0-rc1. > > > > > > Regards, > > > Robbie > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org > > > For additional commands, e-mail: users-h...@qpid.apache.org > > > > > > > > >
