+1 approve
Checklist for reference, Note that this is not official policy but may help with checking releases. Fill in the following: [Y] Checksums and PGP signatures are valid for Source package. [Y] Checksums and PGP signatures are valid for Binary package. [Y] Source code artifacts have correct names matching the current release. [Y] Binary artifacts have correct names matching the current release. [Y] License and Notice are correct in source package. [Y] License and Notice are correct in binary package. [Y] All files have license headers in source package if necessary. [Y] No compiled archives bundled in source archive. [Y] Hash and Tag in GitHub repo is matching the current artifacts. [Y] The code can be built success in the source package. And any other check point is welcomed and please feel free to reply to this email, we sincerely hope to your feedback. At 2019-08-29 19:40:31, "ShannonDing" <[email protected]> wrote: Hello RocketMQ Community, This is the vote for version 1.2.3 of Apache RocketMQ Client CPP. This release included main futures below: Support transaction message. Support C style batch message sending. Support getting error information when C API returns false. Polish the TCP transport layer. Remove useless code and fix compile warnings. For detail info, please see the release note. The artifacts: https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/1.2.3-rc2/ Git tag for the release: https://github.com/apache/rocketmq-client-cpp/tree/release-1.2.3 Hash for the release tag: dcf3a1f0b4c2b9826a391e40d053889ee4fafd91 Release Notes: http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-1.2.3/ The artifacts have been signed with Key : BBC3FBA877D30832E2FBC8F901B994150CD1E262, which can be found in the keys file: https://dist.apache.org/repos/dist/dev/rocketmq/KEYS Checklist for reference, Note that this is not official policy but may help with checking releases. Fill in the following: [] Checksums and PGP signatures are valid for Source package. [] Checksums and PGP signatures are valid for Binary package. [] Source code artifacts have correct names matching the current release. [] Binary artifacts have correct names matching the current release. [] License and Notice are correct in source package. [] License and Notice are correct in binary package. [] All files have license headers in source package if necessary. [] No compiled archives bundled in source archive. [] Hash and Tag in GitHub repo is matching the current artifacts. [] The code can be built success in the source package. And any other check point is welcomed and please feel free to reply to this email, we sincerely hope to your feedback. The vote will be open for at least 72 hours or until necessary number of votes are reached. Please vote accordingly: [] +1 approve [] +0 no opinion [] -1 disapprove with the reason Thanks, The Apache RocketMQ Team
