below I have checked: [OK] Checksums and PGP signatures are valid for Source package.
[OK] Source code artifacts have correct names matching the current release. [OK] License and Notice are correct in source package. [OK] All files have license headers in source package if necessary. [OK] No compiled archives bundled in source archive. [OK] Hash and Tag in GitHub repo is matching the current artifacts. heng du <[email protected]> 于2019年11月22日周五 上午9:18写道： > +1 > > [ OK] Checksums and PGP signatures are valid for the Source package. > > [ OK] License and Notice are correct in source package. > > [ OK] All files have license headers in source package if necessary. > > [ OK] Hash and Tag in GitHub repo are matching the current artifacts. > > > wenfeng wang <[email protected]> 于2019年11月21日周四 下午11:38写道： > >> +1 >> >> ShannonDing <[email protected]> 于2019年11月21日周四 下午9:38写道： >> >>> +1, >>> Before call for this release, I checked: >>> >>> [ OK] Checksums and PGP signatures are valid for Source package. >>> >>> [ OK] Source code artifacts have correct names matching the current >>> release. >>> >>> [ OK] License and Notice are correct in source package. >>> >>> [ OK] All files have license headers in source package if necessary. >>> >>> [ OK] No compiled archives bundled in source archive. >>> >>> [ OK] Hash and Tag in GitHub repo is matching the current artifacts. >>> Any other check point is welcomed. >>> On 11/21/2019 19:20，ShannonDing<[email protected]> <[email protected]> >>> wrote： >>> >>> Hello RocketMQ Community, >>> >>> This is the vote for version 1.2.4 of Apache RocketMQ Client Go(Cgo). >>> >>> >>> The artifacts: >>> >>> >>> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-go/1.2.4-rc1/ >>> >>> Git tag for the release: >>> >>> https://github.com/apache/rocketmq-client-go/releases/tag/v1.2.4 >>> >>> Hash for the release tag: >>> >>> 6bb52431a5eede4b3781d13a90120dea46779669 >>> >>> Release Notes: >>> >>> >>> http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-go-1.2.4/ >>> >>> The artifacts have been signed with Key : >>> >>> BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the keys >>> >>> file: >>> >>> https://dist.apache.org/repos/dist/dev/rocketmq/KEYS >>> >>> >>> Checklist for reference, >>> >>> Note that this is not official policy but may help with checking >>> releases. >>> >>> Fill in the following: >>> >>> [ ] Checksums and PGP signatures are valid for Source package. >>> >>> [ ] Source code artifacts have correct names matching the current >>> release. >>> >>> [ ] License and Notice are correct in source package. >>> >>> [ ] All files have license headers in source package if necessary. >>> >>> [ ] No compiled archives bundled in source archive. >>> >>> [ ] Hash and Tag in GitHub repo is matching the current artifacts. >>> >>> As we don’t release binary package for Apache RocketMQ Go SDK, the >>> binary package checklist should not be followed. >>> >>> And any other check point is welcomed and please feel free to reply to >>> this email, we sincerely hope to your feedback. >>> >>> >>> The vote will be open for at least 72 hours or until necessary number of >>> >>> votes are reached. >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thanks, >>> >>> The Apache RocketMQ Team >>> >>> >>>
