Hi Alina,

Flex SDK events are not written in Java.  Everything is ActionScript.  Flash 
events are written in C and have an ActionScript API surface.  There is no 
UIEvent in Flex that I know of.  You are looking at the third party Batik 
library used for some CSS parsing in the compiler.

References to flash.events.Event in API surfaces like parameters and return 
types should be replaced by org.apache.flex.events.Event.
Flash.events.MouseEvent should be replaced by org.apache.flex.events.MouseEvent.
Flash.events.IEventDispatcher should be replaced by 
org.apache.flex.events.IEventDispatcher.
Flash.events.EventDispatcher should be replaced by 
org.apache.flex.events.EventDispatcher.

The internal implementation can still use flash.*.* if it is in COMPILE::SWF 
blocks.

HTH,
-Alex

From: Alina Kazi <alina.k...@d-bz.com<mailto:alina.k...@d-bz.com>>
Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Date: Tuesday, April 3, 2018 at 11:14 PM
To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Subject: RE: Work on Emulation

Hi Alex,

Flex-SDK Events like MouseEvent, UIEvent,TextEvent are written in Java.
flex-sdk\modules\thirdparty\batik\sources\org\w3c\dom\events
We can use them directly in Apache Royale as we were using them in Flex SDK 
,right?

-Alina Kazi

From: Alina Kazi [mailto:alina.k...@d-bz.com]
Sent: Wednesday, April 04, 2018 10:38 AM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: RE: Work on Emulation

Thanks Peter

From: Peter Ent [mailto:p...@adobe.com]
Sent: Tuesday, April 03, 2018 10:24 PM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: Re: Work on Emulation

Hi Alina,

I've merged your VRule and HRule changes. Thanks for making them!

—peter

From: Alina Kazi <alina.k...@d-bz.com<mailto:alina.k...@d-bz.com>>
Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Date: Tuesday, April 3, 2018 at 8:22 AM
To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Subject: RE: Work on Emulation

Thanks Alex
Now I am working on    : Tile and TileDirection
Both files are compiled successfully after changes
Pull Request : 
https://github.com/apache/royale-asjs/pull/143<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com%7C94c698cf7a014b81a74008d5995da363%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636583549810355444&sdata=ZXz0nQrRSl3rpV7yz9AvXkaXg%2BVTBCWk7ZbTOzTEdp8%3D&reserved=0>

Only a Warning in Tile.as
What I should do to remove that warning
[java] D:\outtest\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\
mx\containers\Tile.as(277): col: 5 public var may not work in minified JS output
.  Use getter/setter instead.
     [java]
     [java]     mx_internal var cellWidth:Number;

Thanks,
Alina Kazi
From: Alex Harui [mailto:aha...@adobe.com]
Sent: Tuesday, April 03, 2018 12:27 PM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: Re: Work on Emulation

Hi Alina,

Congratulations!  I merged your pull request.  You have now contributed code to 
Apache Royale.

You should be able to use mx_internal now.  I pushed those changes earlier.

I'm done for today, hopefully Peter or Piotr will review the Hrule/Vrule pull 
request.  Please make sure there are no warnings in the build.  I updated 
ListEvent and SliderEvent to suppress warnings.

Thanks,
-Alex

From: Alina Kazi <alina.k...@d-bz.com<mailto:alina.k...@d-bz.com>>
Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Date: Monday, April 2, 2018 at 11:25 PM
To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Subject: RE: Work on Emulation

Thanks alot Peter and Alex.
HRule and VRule Files are added to new Branch and Compiled Successfully
https://github.com/alinakazi/royale-asjs/tree/alinakazi-HRuleVRule/frameworks/projects/MXRoyale/src/main/royale/mx/controls<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falinakazi%2Froyale-asjs%2Ftree%2Falinakazi-HRuleVRule%2Fframeworks%2Fprojects%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontrols&data=02%7C01%7Caharui%40adobe.com%7Cf803a2f5bfae4b51df5508d5992bc5ff%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636583335664948195&sdata=0wAuwW7NcLkLbUw6yQkidChhJ5t7sxVR9aDt%2Fdqcbm0%3D&reserved=0>

In Panel :  I will also replace “mx_internal“  with "protected"
And comment-out all functions and/or variables that referencing something not 
yet ported.

Alina Kazi
From: Alex Harui [mailto:aha...@adobe.com]
Sent: Monday, April 02, 2018 8:28 PM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: Re: Work on Emulation

Hi Alina,

mx_internal methods may not need to be ported.  If they are not listed in the 
list of API s you used in your app, the next question is whether they are 
needed to emulate the functionality of the component that you do use.  In many 
cases they are not needed.

I am working on getting mx_internal working on the JS side.  Even though 
mx_internal APIs are not supported by Flex, I don't doubt that other namespaces 
are used somewhere so we should try to get it to work.  It has been working in 
simple test cases so not sure yet why it isn't working in the emulation 
components.

Thanks,
-Alex

From: Peter Ent <p...@adobe.com<mailto:p...@adobe.com>>
Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Date: Monday, April 2, 2018 at 7:06 AM
To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Subject: Re: Work on Emulation

Hi Alina,

Sorry for the delayed response.

First, try to port over something easier like VRule and HRule as a first step 
since these are less complex.

As for mx_internal - I have been changing these to "protected".

Once you do that you'll find that you will also need IUITextField. I haven't 
done that but I just took a look at it. You can do a couple of things:

In Panel (and any where else), comment-out any function or variable that 
references something not yet ported. We are trying to pass compilation, so that 
would be OK at this stage.

If you feel you need to bring something else over, then you have to go through 
the same process of course. Since you can wind up following class and interface 
down a long chain, I would just comment-out things complex. Sometimes I am left 
with "implements IUIComponent" and the rest of the interfaces listed in a class 
are put into comments.

I hope that helps.
—peter

From: Alina Kazi <alina.k...@d-bz.com<mailto:alina.k...@d-bz.com>>
Reply-To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Date: Monday, April 2, 2018 at 7:43 AM
To: "users@royale.apache.org<mailto:users@royale.apache.org>" 
<users@royale.apache.org<mailto:users@royale.apache.org>>
Subject: RE: Work on Emulation

mx.containers.Panel
Panel.as file contains many variables and methods that are using mx_internal 
e.g. Variable
  mx_internal var _showCloseButton:Boolean = false;

Method
  mx_internal function getStatusTextField():IUITextField
    {
        return statusTextField;
    }
As use namespace mx_internal; and import mx.core.mx_internal; are commented in 
source files .
I am getting errors on these variables and methods e.g.
     [java]
D:\out\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\containers\Panel.as(1796):
col: 6 function 'getStatusTextField' will be scoped to  the default namespace: 
mx.containers.Panel: internal.
It will not be visible outside of this package.
     [java]
     [java]      function getStatusTextField():IUITextField

Should I comment all of these variables and methods ?
Or
Should I make all of these variables and methods Public?

For Reference, I am sharing link. So you don't need to find this file in 
flex-sdk , You can find the at:
Flex-sdk  mx.containers.Panel: 
https://www.dropbox.com/s/6xb1jp2efwuwnam/PanelFlex.as?dl=0<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.dropbox.com%2Fs%2F6xb1jp2efwuwnam%2FPanelFlex.as%3Fdl%3D0&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=xLjL8AM45ZA2E8IRILbskD04cJCL9SVSc5Fi0%2BO98Tg%3D&reserved=0>
Royale 
:https://github.com/alinakazi/royale-asjs/blob/mxRoyalePanel/frameworks/projects/MXRoyale/src/main/royale/mx/containers/Panel.as<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falinakazi%2Froyale-asjs%2Fblob%2FmxRoyalePanel%2Fframeworks%2Fprojects%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontainers%2FPanel.as&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=Zwbl%2B2eMeQIsuoDCI4mfZ1A4TF3cA%2FcSqlzq53DEO5Y%3D&reserved=0>

Thanks in Advance.
Alina

From: Alina Kazi [mailto:alina.k...@d-bz.com]
Sent: Monday, April 02, 2018 3:25 PM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: RE: Work on Emulation


Thanks ☺
New branch Created :
https://github.com/alinakazi/royale-asjs/tree/mxRoyalePanel<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyalePanel&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=AbVDtIurdRp7fwqDGrLxUrQqYXv8EvuTwCDw7%2BWMBtc%3D&reserved=0>

Copied MX Panel from flex-sdk to New branch (mxRoyalePanel)
Pull Request :
https://github.com/apache/royale-asjs/pull/141<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F141&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=sVStAHTosnX0lBpTYWRCEC23BiiVaX8t1%2F08YICYjOs%3D&reserved=0>

-Alina Kazi


From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com]
Sent: Monday, April 02, 2018 1:22 PM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: Re: Work on Emulation

Alina,

You cannot delete pull request. You can only close it, so we are good with 139 
and 140. They are closed.

Your pull request 138 now looks great! :)

Whenever you are going to push some bigger changes you should create new 
branches. If you are working right now on Panel - probably new branch with your 
changes would be the best. Our pull request will looks than cleaner. - That is 
just my recommendation.

In general congrats for your first pull request to Apache Royale project!! :)

Thanks,
Piotr

2018-04-02 8:08 GMT+02:00 Alina Kazi 
<alina.k...@d-bz.com<mailto:alina.k...@d-bz.com>>:
Hi Piotr,

Thanks Piotr.

I am trying to add another pull request for SliderEvent.as file. but when I
added this file manually at
https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/projects
/MXRoyale/src/main/royale/mx/events<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleAQ%2Fframeworks%2Fprojects%250d%250a%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fevents&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=rhi6Z0g%2B6UCXr%2Btgp5gpKFrmdaajqYLlmTh7iNvdoCU%3D&reserved=0>
and commit it.
Commit auto added to previous Pull Request :
https://github.com/apache/royale-asjs/pull/138<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F138&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=a1%2BNp%2Ft3M7aSPIwqN%2BQt7XY50OX%2BSwRDB%2FACRJhWLH4%3D&reserved=0>

Is it ok to do multiple commits on same pull Request instead of creating New
Pull Request for each file?

How Can I delete these Closed Pull Requests?
https://github.com/apache/royale-asjs/pull/139<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F139&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=apy1DAJqmHGIjCdQDz4g0K36NbZATtHhA%2Foqc659Bjs%3D&reserved=0>
and
https://github.com/apache/royale-asjs/pull/140<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F140&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=XehX29ItsGAwo33xue7KI9uD4PEJS3gGhS7ad1E7iSk%3D&reserved=0>


-Alina



-----Original Message-----
From: piotrz [mailto:pio...@apache.org<mailto:pio...@apache.org>]
Sent: Friday, March 30, 2018 5:14 PM
To: users@royale.apache.org<mailto:users@royale.apache.org>
Subject: Re: Work on Emulation
I see your new pull request and it doesn't looks good. [1] As you can see on
the screenshot you did it against develop from feature/MXRoyale and it
contains 94 commits.

<http://apache-royale-users.20374.n8.nabble.com/file/t1/new_pull_request.png<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-royale-users.20374.n8.nabble.com%2Ffile%2Ft1%2Fnew_pull_request.png&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=O0UU8UF57g%2BxBjEm1BU%2BDdoyAqaNEMxwl%2FQijXxEDKQ%3D&reserved=0>
>

The old one is being done correctly. You have used your branch ->
apache:feature/MXRoyale from alinakazi:mxRoyaleAQ

<http://apache-royale-users.20374.n8.nabble.com/file/t1/old_pull_Request.png<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-royale-users.20374.n8.nabble.com%2Ffile%2Ft1%2Fold_pull_Request.png&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=wY1dxwYu%2B2G%2Be3czhrayFYw7FGgBmQIqic7v26mzqEk%3D&reserved=0>
>

[1] 
https://github.com/apache/royale-asjs/pull/139/commits<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F139%2Fcommits&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=HUrVPryVBIrheFbS%2BzRap%2BPpOrVETRJB%2Fh630nCVWPo%3D&reserved=0>

Thanks,
Piotr



--
Sent from: 
http://apache-royale-users.20374.n8.nabble.com/<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-royale-users.20374.n8.nabble.com%2F&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=pfDAW81u489DuWy0Gc80ll1HzseZk5gMhoneBuYpCJQ%3D&reserved=0>



--

Piotr Zarzycki

Patreon: 
https://www.patreon.com/piotrzarzycki<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=7xFAD19Wk39S%2BJEn6QB6jibV8%2B7Y9O8Ee16CAVyZPTk%3D&reserved=0>

Reply via email to