Hi Serkan,
Well, it isn't that what you did wasn't "right". It was right for
the SWF implementation, but the emulation still needs an actual JS
implementation. For other emulation components we are just getting
the JS compile to complete without error and worry about the working
implementation later, but since these encoders are relatively
independent you might as well decide on the JS implementation now.
Thanks,
-Alex
From: Serkan Taş
<[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Tuesday, April 17, 2018 at 2:22 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
Alex,
after putting flash.utils.ByteArray input and related function into
COMPILE:SWF blocks both objects compiles without error.
from your comment i see that this is not the right way.
I am going to work on two alternatives;
1. To switch the internals of a component that uses ByteArray to BinaryData
2. Find a different implementation for JS (
https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_2_–_rewrite_the_DOMs_atob()_and_btoa()_using_JavaScript's_TypedArrays_and_UTF-8<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.mozilla.org%2Fen-US%2Fdocs%2FWeb%2FAPI%2FWindowBase64%2FBase64_encoding_and_decoding%23Solution_2_%25E2%2580%2593_rewrite_the_DOMs_atob%2528%2529_and_btoa%2528%2529_using_JavaScript%2527s_TypedArrays_and_UTF-8&data=02%7C01%7Caharui%40adobe.com%7C289aa0b43c5241f253d808d5a4a95382%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636595969552886792&sdata=ddcLvvybPs9hNxYi4ynQTPE%2FBe3bu7A7XeFVbzljqBo%3D&reserved=0>)
Thanks.
18.04.2018 00:11 tarihinde Alex Harui yazdı:
Just to be sure we're all in sync:
Folks using flash classes in their apps will have to replace them.
We've created an mx.system.ApplicationDomain to replace
flash.system.ApplicationDomain since this first round of emulations
isn't really going to support ApplicationDomains. And
flash.utils.ByteArray should be replaceable by
org.apache.royale.utils.BinaryData.
Folks creating emulation components can choose to switch the
internals of a component that uses ByteArray to BinaryData, or come
up with a different implementation for JS. And in this case, there
might be some good alternatives. See:
https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_2_–_rewrite_the_DOMs_atob()_and_btoa()_using_JavaScript's_TypedArrays_and_UTF-8<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdeveloper.mozilla.org%2Fen-US%2Fdocs%2FWeb%2FAPI%2FWindowBase64%2FBase64_encoding_and_decoding%23Solution_2_%25E2%2580%2593_rewrite_the_DOMs_atob%2528%2529_and_btoa%2528%2529_using_JavaScript%2527s_TypedArrays_and_UTF-8&data=02%7C01%7Caharui%40adobe.com%7C289aa0b43c5241f253d808d5a4a95382%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636595969552886792&sdata=ddcLvvybPs9hNxYi4ynQTPE%2FBe3bu7A7XeFVbzljqBo%3D&reserved=0>
Either way is fine for now.
-Alex
From: Greg Dove <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Tuesday, April 17, 2018 at 2:00 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
Sounds like you figured it out, great! And yes, BinaryData has that
same approach.
There are probably much easier and faster ways to do the base64
conversion directly in COMPILE::JS blocks, so I maybe you will use
those for js.
On Wed, Apr 18, 2018 at 8:55 AM, Serkan Taş
<[email protected]<mailto:[email protected]>>
wrote:
Thanks Greg,
I checked the documentation;
The internal implementation can still use flash.*.* if it is in
COMPILE::SWF blocks.
And the BinarayData.as has also the same approach.
Serkan.
17.04.2018 23:51 tarihinde Greg Dove yazdı:
Hi Serken, you could try using the BinaryData class, it has many of
the same methods that ByteArray has
On Wed, Apr 18, 2018 at 8:39 AM, Serkan Taş
<[email protected]<mailto:[email protected]>>
wrote:
Hi,
When working on Base64Encoder.as, it seems that without import
flash.utils.ByteArray it is not so useful. I tought, there should be
equivalent in royale for this basic object type.
otherwise removing this import, nearly means removing the object
Base64Encoder.
am i wrong ?
17.04.2018 23:11 tarihinde Serkan Taş yazdı:
Hi Alex,
We can work this way, i do not need permission to edit the issue anymore.
Ant the compile errors are gone :
In folder royale-asjs :
git pull
mvn clean install
in folder MXRoyale :
mvn clean install
Thanx
Serkan
16.04.2018 23:36 tarihinde Alex Harui yazdı:
Hi Serkan,
I checked those boxes for you. Not sure how to get you rights to do
that yourself.
I also just pushed changes to fix the Maven build. Hopefully it
will work for you now.
Thanks,
-Alex
From: Serkan Taş
<[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Monday, April 16, 2018 at 1:05 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
Hi Alex,
How can i edit the issue ? I think i need permission.
I am planning to start with these two :
*
mx.utils.Base64Decoder
* mx.utils.Base64Encoder
Note : I m getting compile errors for royale-asjs related with some
of the components :
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\BarChart.as(21): col: 9 Warning: Definition org.apache.royale.charts.BarChart could
no
t be found.
import org.apache.royale.charts.BarChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\ColumnChart.as(21): col: 9 Warning: Definition org.apache.royale.charts.ColumnChart
co
uld not be found.
import org.apache.royale.charts.ColumnChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\LineChart.as(21): col: 8 Warning: Definition org.apache.royale.charts.LineChart
could
not be found.
import org.apache.royale.charts.LineChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\PieChart.as(21): col: 9 Warning: Definition org.apache.royale.charts.PieChart could
no
t be found.
import org.apache.royale.charts.PieChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\chartClasses\ChartBase.as(21): col: 9 Warning: Definition
org.apache.royale.charts.cor
e.ChartBase could not be found.
import org.apache.royale.charts.core.ChartBase;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\chartClasses\ChartBase.as(39): col: 33 Error: The definition of base class ChartBase
w
as not found.
public class ChartBase extends
org.apache.royale.charts.core.ChartBase
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Move.as(23): col: 8 Warning: Definition org.apache.royale.effects.Move could not be
f
ound.
import org.apache.royale.effects.Move;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Move.as(34): col: 27 Error: The definition of base class Move was not
found.
public class Move extends org.apache.royale.effects.Move
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Resize.as(22): col: 8 Warning: Definition org.apache.royale.effects.Resize could
not
be found.
import org.apache.royale.effects.Resize;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Resize.as(33): col: 29 Error: The definition of base class Resize was not
found.
public class Resize extends org.apache.royale.effects.Resize
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Tween.as(23): col: 8 Warning: Definition org.apache.royale.effects.Tween could not
be
found.
import org.apache.royale.effects.Tween;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Tween.as(46): col: 28 Error: The definition of base class Tween was not
found.
public class Tween extends org.apache.royale.effects.Tween
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\BarChart.as(21): col: 9 Definition org.apache.royale.charts.BarChart could not be
foun
d.
import org.apache.royale.charts.BarChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\ColumnChart.as(21): col: 9 Definition org.apache.royale.charts.ColumnChart could not
b
e found.
import org.apache.royale.charts.ColumnChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\LineChart.as(21): col: 8 Definition org.apache.royale.charts.LineChart could not be
fo
und.
import org.apache.royale.charts.LineChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\PieChart.as(21): col: 9 Definition org.apache.royale.charts.PieChart could not be
foun
d.
import org.apache.royale.charts.PieChart;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\chartClasses\ChartBase.as(21): col: 9 Definition
org.apache.royale.charts.core.ChartBa
se could not be found.
import org.apache.royale.charts.core.ChartBase;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\charts\chartClasses\ChartBase.as(39): col: 33 The definition of base class ChartBase was
not
found.
public class ChartBase extends
org.apache.royale.charts.core.ChartBase
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Move.as(23): col: 8 Definition org.apache.royale.effects.Move could not be
found.
import org.apache.royale.effects.Move;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Move.as(34): col: 27 The definition of base class Move was not
found.
public class Move extends org.apache.royale.effects.Move
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Resize.as(22): col: 8 Definition org.apache.royale.effects.Resize could not be
found.
import org.apache.royale.effects.Resize;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Resize.as(33): col: 29 The definition of base class Resize was not
found.
public class Resize extends org.apache.royale.effects.Resize
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Tween.as(23): col: 8 Definition org.apache.royale.effects.Tween could not be
found.
import org.apache.royale.effects.Tween;
^
D:\dev\git\emulation_works\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\effects\Tween.as(46): col: 28 The definition of base class Tween was not
found.
public class Tween extends org.apache.royale.effects.Tween
^
4.841137664 seconds
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 8.283 s
[INFO] Finished at: 2018-04-16T23:03:41+03:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.royale.compiler:royale-maven-plugin:0.9.3-SNAPSHOT:compile-as
(default-compile-as) on project MXRoyale: There were errors during
the build
. Got return code 3 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible
solutions, please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FMAVEN%2FMojoExecutionException&data=02%7C01%7Caharui%40adobe.com%7C49ae9a45f6c34022eb5808d5a3d58a61%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636595060026875814&sdata=5qaaZ9kFpnsfFWFfGU%2FMBZ%2FWT2fSuuRXlUfLeAhPaN0%3D&reserved=0>
14.04.2018 02:15 tarihinde Alex Harui yazdı:
Alina,
Are you sure you are compiling the files before submitting the PR?
I had to fix the build dependencies for effects and graphics. I
would have thought you would have run into that first.
Thanks,
-Alex
From: Alex Harui <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Thursday, April 12, 2018 at 8:55 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
Copying files doesn't sound right to me. I haven't done pull
requests myself since I always have had write access to the repos.
Here is one article about a workflow.
https://gist.github.com/Chaser324/ce0505fbed06b947d962<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgist.github.com%2FChaser324%2Fce0505fbed06b947d962&data=02%7C01%7Caharui%40adobe.com%7C31b4222012ce49c4a05d08d5a08de1ff%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636591453674021207&sdata=HWKNU%2F8iR0Fv%2FdNQgvSNMsX0R46j9ro5WY6O7etYRp8%3D&reserved=0>
HTH,
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Thursday, April 12, 2018 at 2:19 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Hi Alex,
D:\myRepository\royale-asjs>git pull --rebase
There is no tracking information for the current branch.
Please specify which branch you want to rebase against.
See git-pull(1) for details.
git pull <remote> <branch>
If you wish to set tracking information for this branch you can do so with:
git branch --set-upstream-to=<remote>/<branch> feature/mxRoyale
I don’t want to update my local repo D:\myRepository\royale-asjs. it
is already updated by copying apache:feature/MXRoyale(local system)
files to alinakazi:feature/mxRoyale(local system)
I want to sync my live repository
alinakazi:feature/mxRoyale branch:
https://github.com/alinakazi/royale-asjs/tree/feature/MXRoyale<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falinakazi%2Froyale-asjs%2Ftree%2Ffeature%2FMXRoyale&data=02%7C01%7Caharui%40adobe.com%7Cf22566583b324247786708d5a056acb5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636591216504791957&sdata=pMdsM6NUdJalCCQ6g%2Bz3nE1euprxspMgaHIJdCHci%2Bs%3D&reserved=0>
with
apache:feature/MXRoyale branch:
https://github.com/apache/royale-asjs/tree/feature/MXRoyale<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Ftree%2Ffeature%2FMXRoyale&data=02%7C01%7Caharui%40adobe.com%7Cf22566583b324247786708d5a056acb5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636591216504791957&sdata=rzZRGiOVBvnkNnWr7AWdD09Z90fvn8LBrwZ5tMzH4tw%3D&reserved=0>
as alinakazi:feature/mxRoyale branch is 5 commits ahead, 328 commits
behind apache:feature/MXRoyale.
alinakazi/royale-asjs forked from apache/royale-asjs
Thanks,
Alina Kazi
From: Alex Harui [mailto:[email protected]]
Sent: Thursday, April 12, 2018 12:42 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
I think you want to either "git pull —rebase" in your
feature/MXRoyale branch, or if you get a lot of conflicts, try just
"git pull". Yet another option is to just delete your working copy
and pull the whole thing down again. I think you want to run "git
pull —rebase" as you start your day so you keep up with the latest
code.
HTH,
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Wednesday, April 11, 2018 at 10:52 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Thank you Alex.
Whenever I start working on new files or a particular API, I always
create a sub branch from alinakazi:feature/MXRoyale.
I added solidcolor directly to alinakazi:feature/MXRoyale by mistake
and added a new pull request.
I am trying to delete solidcolor from alinakazi:feature/MXRoyale
unable to delete it.
Whenever I create sub branch from alinakazi:feature/MXRoyale
solidcolor commits are already added in the sub branch & when I
create a pull request
apache:feature/MXRoyale<- alinakazi:subbranch (new changes in sub
branch + previous 5 commits from alinakazi:feature/MXRoyale are
added in pull request )
How can I sync my alinakazi:feature/mxRoyale branch
https://github.com/alinakazi/royale-asjs/tree/feature/MXRoyale<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falinakazi%2Froyale-asjs%2Ftree%2Ffeature%2FMXRoyale&data=02%7C01%7Caharui%40adobe.com%7C7c762d8be5004b4869f308d5a039a96c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636591092030940497&sdata=QaGXhJ0RSvPsTVpJl1D1Jv2dZDU6NHMUBwMQzs7xJDE%3D&reserved=0>
with apache:feature/MXRoyale branch
https://github.com/apache/royale-asjs/tree/feature/MXRoyale<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Ftree%2Ffeature%2FMXRoyale&data=02%7C01%7Caharui%40adobe.com%7C7c762d8be5004b4869f308d5a039a96c%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636591092030940497&sdata=9RqLQhRs2TPLNj55HryYi0zYPmQYprUaZ6ucJNhdFng%3D&reserved=0>
Current Status:
alinakazi:feature/MXRoyale : This branch is 5 commits ahead, 328
commits behind apache:feature/MXRoyale.
Thanks,
Alina Kazi
From: Alex Harui [mailto:[email protected]]
Sent: Wednesday, April 11, 2018 8:39 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
If your use of ApplicationDomain is to create new domains or pass
domains into certain Flash APIs, using Object for now will probably
work. If you used ApplicationDomain for
hasDefinition/getDefinition, the choices are to switch to using
org.apache.royale.reflection.getDefinitionByName or creating some
other package for ApplicationDomain like mx.system.ApplicationDomain
and wrapping that around that calls to
org.apache.royale.reflection.getDefinitionByName so you only have to
change the import package from flash.system.ApplicationDomain to
mx.system.ApplicationDomain.
I'm trying to avoid having us emulate flash.*.* classes. It could
turn into an attempt to emulate the Flash Player which is more than
we have time for, and it helps us see where folks have dependencies
on Flash.
Thanks,
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Wednesday, April 11, 2018 at 12:33 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Thank you so much Alex.
Files added for the emulation of mx.graphics.GradientEntry by
subclassing org.apache.royale.graphics.GradientEntry
mx.graphics.IFill by subclassing org.apache.royale.graphics. IFill,
mx.graphics.IStroke by subclassing org.apache.royale.graphics. IStroke,
mx.graphics.SolidColor by subclassing org.apache.royale.graphics.
SolidColor and
mx.graphics.SolidColorStroke by subclassing
org.apache.royale.graphics. SolidColorStroke.
As per your suggestion:
For now, I will replace ApplicationDomain with Object or comment it.
and SecurityDomain is not directly used by my Application. I will
replace with Object or comment it, in the API’s that are used by my
Application.
-Alina
From: Alex Harui [mailto:[email protected]]
Sent: Tuesday, April 10, 2018 9:25 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
It is up to you. These classes have a different package name in
Royale
(org.apache.royale.graphics.Gr<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Forg.apache.royale.graphics.Gr&data=02%7C01%7Caharui%40adobe.com%7C17e2809e7c5a494da4d808d5a4a6520e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636595956649829809&sdata=kpNtGtnR%2FRXJ3AJX74moppfES4q5sJcw%2BFV4SAmTUb8%3D&reserved=0>adientEntry instead of mx.graphics.GradientEntry). You can replace all occurrences in your app of mx.graphics.GradientEntry with org.apache.royale.graphics.GradientEntry or create the emulation of mx.graphics.GradientEntry by subclassing
org.apache.royale.graphics.GradientEntry.
I would recommend subclassing so you and other migrating folks don't
have to touch the source code.
Where are you running into use of ApplicationDomain and SecurityDomain?
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Tuesday, April 10, 2018 at 4:53 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Do we need to add below mentioned classes in mxRoyale Branch?
mx.graphics.GradientEntry
mx.graphics.IFill
mx.graphics.IStroke
mx.graphics.SolidColor
mx.graphics.SolidColorStroke
as these are already present in
https://github.com/apache/royale-asjs/tree/feature/MXRoyale/frameworks/projects/Graphics/src/main/royale/org/apache/royale/graphics<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Ftree%2Ffeature%2FMXRoyale%2Fframeworks%2Fprojects%2FGraphics%2Fsrc%2Fmain%2Froyale%2Forg%2Fapache%2Froyale%2Fgraphics&data=02%7C01%7Caharui%40adobe.com%7C2d1f1876e0dc49c60dbb08d59ed9bf50%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636589580442365750&sdata=M7HXTyNx7qBlLX1l9frY8ALqvG93b%2Fj56iRCov%2FXzws%3D&reserved=0>
also import flash.system.ApplicationDomain & import
flash.system.SecurityDomain are used in most of the API’s in list
https://github.com/apache/royale-asjs/issues/136<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Caharui%40adobe.com%7C2d1f1876e0dc49c60dbb08d59ed9bf50%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636589580442365750&sdata=XNDI%2BiXPuIcHSnCqPj%2Fhl0L8RL49B7yIHJ1%2BPJJaGB0%3D&reserved=0>
Is these any alternate for them? Or We need to comment these API’s
and Methods using these API’s
Thanks,
Alina
From: Alina Kazi [mailto:[email protected]]
Sent: Tuesday, April 10, 2018 4:20 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
What are the alternative API's for
import flash.system.ApplicationDomain;
import flash.system.SecurityDomain;
Thanks in Advance,
Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Tuesday, April 10, 2018 2:46 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
mx.effects.effectClasses
mx.controls.listClasses
mx.controls.advancedDataGridClasses
mx.controls.dataGridClasses
mx.charts.chartClasses
mx.controls.textClasses
mx.controls.treeClasses
are deleted and
mx.effects.effectClasses.CompositeEffectInstance
mx.effects.effectClasses.TweenEffectInstance
mx.controls.listClasses.AdvancedListBase
mx.controls.listClasses.BaseListData
mx.controls.listClasses.ListBase
mx.controls.advancedDataGridClasses.AdvancedDataGridColumn
mx.controls.advancedDataGridClasses.AdvancedDataGridColumnGroup
mx.controls.advancedDataGridClasses.AdvancedDataGridHeaderRenderer
mx.controls.advancedDataGridClasses.AdvancedDataGridItemRenderer
mx.controls.dataGridClasses.DataGridColumn
mx.charts.chartClasses.CartesianTransform
mx.charts.chartClasses.ChartBase
mx.charts.chartClasses.DataTip
mx.charts.chartClasses.DataTransform
mx.charts.chartClasses.GraphicsUtilities
mx.charts.chartClasses.RenderData
mx.charts.chartClasses.Series
mx.controls.textClasses.TextRange
mx.controls.treeClasses.ITreeDataDescriptor
mx.controls.treeClasses.TreeItemRenderer
mx.controls.treeClasses.TreeListData
are added to
https://github.com/apache/royale-asjs/issues/136<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Caharui%40adobe.com%7C2d1f1876e0dc49c60dbb08d59ed9bf50%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636589580442365750&sdata=XNDI%2BiXPuIcHSnCqPj%2Fhl0L8RL49B7yIHJ1%2BPJJaGB0%3D&reserved=0>
Now, Total API’s are 260 and 25%(65) of them are compiled Successfully.
From: Alina Kazi [mailto:[email protected]]
Sent: Tuesday, April 10, 2018 11:30 AM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Updated the checkboxes again.
Now the status is 64 of 246.
-Alina
From: Alex Harui [mailto:[email protected]]
Sent: Tuesday, April 10, 2018 11:01 AM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hmm. That might be a bug in the GitHub checkbox handling. It might
be that if I forget to refresh the issue before checking a box that
it will overwrite your changes. Please try updating the checkboxes
again and I'll be more careful going in the future.
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Monday, April 9, 2018 at 10:15 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Alex , I update the GitHub issue regularly. When I visit next day
many checkboxes that I checked earlier are unchecked.
Yesterday at 5:30 the status was 62 of 246 and now It is 42 of 246
Thanks,
Alina Kazi
From: Alex Harui [mailto:[email protected]]
Sent: Monday, April 09, 2018 10:10 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Alina, please make sure you are updating the GitHub issue and
checking off the components you are working on.
Thanks,
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Monday, April 9, 2018 at 5:17 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
https://github.com/apache/royale-asjs/pull/157<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F157&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=vhHts63uovMIbWe0PiF8et8XAaeGz%2BZQMR6EJbB8DT0%3D&reserved=0>
for mx.core.EventPriority
-Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Monday, April 09, 2018 4:45 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
https://github.com/apache/royale-asjs/pull/156<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F156&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=In0o4Xm2YQzjpftUCCsb3gbQjDEeIZpArrL%2FeqXRdS0%3D&reserved=0>
for IViewCursor and ICollectionView
-Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Monday, April 09, 2018 3:55 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Please review and/or comment on the changes in pull request For
SandboxMouseEvent and ResizeEvent
https://github.com/apache/royale-asjs/pull/155<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F155&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=AO4CEGJ1mBZZEbSsyu3xFEJUFf9okyLw2Vvdz2xE8PY%3D&reserved=0>
Thanks in Advance ☺
Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Monday, April 09, 2018 2:57 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Also review Pull Request for mx.effects.IEffectInstance and
mx.events.EffectEvent
https://github.com/apache/royale-asjs/pull/153<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F153&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=RvzoCVZ4%2Bj3kynbl9dJ55AsCVybnYSiYV1RRhjtjraA%3D&reserved=0>
Thanks in Advance ☺
Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Monday, April 09, 2018 12:04 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Could Someone Please Review these Pull Requests
https://github.com/apache/royale-asjs/pull/150<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F150&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=zFVy9NRGJA3Xk07h2HOeK0RKw37fWonB6YylQbuam%2Fo%3D&reserved=0>
https://github.com/apache/royale-asjs/pull/151<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F151&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=8ldkryGRY%2BCgCd76ehFzXanJr5HPN6%2B4OSbo4jEMskk%3D&reserved=0>
https://github.com/apache/royale-asjs/pull/152<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F152&data=02%7C01%7Caharui%40adobe.com%7Ccc5b2179b21d43aada6508d59e140896%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588731262059074&sdata=BLy8FNQU3I0nIUjqPmSG6UzMA2vdXnhkY%2BoKCt8SlOw%3D&reserved=0>
Thanks in Advance ☺
Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Monday, April 09, 2018 10:25 AM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Thanks Peter.
From: Peter Ent [mailto:[email protected]]
Sent: Friday, April 06, 2018 7:59 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
I merged these changes into the MXRoyale branch. They compiled cleanly.
Great job!
—peter
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Friday, April 6, 2018 at 6:56 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>,
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Please Review :
https://github.com/apache/royale-asjs/pull/145<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F145&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=zcPe%2FP5GfVBjQADjvgZ0aba5uxIXwZEtyErETijQ8i8%3D&reserved=0>
https://github.com/apache/royale-asjs/pull/149<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F149&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=GPKxD8qY%2Bjbo5aJu9Ws5a7fvy9NUF2rSy1WnpbSK%2Fxo%3D&reserved=0>
Thanks,
Alina Kazi
From: Alina Kazi [mailto:[email protected]]
Sent: Friday, April 06, 2018 2:33 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Thanks Piotr.
From: Piotr Zarzycki [mailto:[email protected]]
Sent: Friday, April 06, 2018 12:32 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
One suggestion to the reporting in [1] - Could you please bold "in
progress" status ? I just did for you now, but in the next which you
will work please do so. It's much better visible.
[1]
https://github.com/apache/royale-asjs/issues/136<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=gpILHV94aescQfiVffhg2qvJl8EZETzx%2FsiSUWsY9x0%3D&reserved=0>
Thanks,
Piotr
2018-04-06 9:28 GMT+02:00 Alina Kazi
<[email protected]<mailto:[email protected]>>:
Currently I am working on mx.collections.Sort and
mx.collections.SortField from list.
Dependencies Added :
mx.collections.errors.SortError , mx.collections.ISort and
mx.collections.ISortField are emulated as these API's were used in
mx.collections.Sort and mx.collections.SortField.
Dependencies Commented :
mx.resources.IResourceManager and mx.resources.ResourceManager
What are the alternative API's for
import flash.system.ApplicationDomain;
import flash.system.SecurityDomain;
Pull Request :
https://github.com/apache/royale-asjs/pull/148<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Froyale-asjs%2Fpull%2F148&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=AXamSfkxcP3Noeq03HlBtfEDoYDtRLwf8A6e4fExs3Y%3D&reserved=0>
Thanks,
Alina Kazi
-----Original Message-----
From: Alina Kazi [mailto:[email protected]<mailto:[email protected]>]
Sent: Friday, April 06, 2018 10:57 AM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Sure, I will pick APIs from the List next time.
Thanks,
Alina Kazi
-----Original Message-----
From: Alex Harui [mailto:[email protected]<mailto:[email protected]>]
Sent: Wednesday, April 04, 2018 8:45 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
I am not seeing Tile in the list of APIs your application used. We
should only be working on classes used by your app.
Thanks,
-Alex
On 4/4/18, 8:03 AM, "Peter Ent"
<[email protected]<mailto:[email protected]>> wrote:
Hi Alina,
The CloseEvent looks fine.
In the others, the [IconFile] needs to be removed. If you have removed
it I didn't see the deletion in the pull request.
For Tile, I think that needs more work, unless I'm not reading the pull
request correctly. You should remove most of the contents of this file.
When we get to making Tile work, we have a Tile layout in Royale
already and chances the MX Tile will be implemented using the
Royale TileLayout.
But if not we can always go back and bring in code from the original
and re-work it then.
Thanks,
Peter
On 4/4/18, 6:15 AM, "Alina Kazi"
<[email protected]<mailto:[email protected]>> wrote:
Branch->mxRoyaleTileandTileDirection
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleTileandTileDirection&data
=02
%
7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7
b34
4
38794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=ri9QIFg3k4H9Msm
Yy0
c
C48iy97u%2FZkSlAL0jPwlwoYE%3D&reserved=0
Pull Request
:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
om%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>
%7C
1
9e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
%7C
%7C636584337418853728&sdata=Q%2B%2FhMzYPx5Eklaicfgeo8p9S9EaAZfbMy6%2B0
UXc
v
b5s%3D&reserved=0
Tile.as
TileDirection.as
Branch->MxRoyaleCloseEvent
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FMxRoyaleCloseEvent&data=02%7C01%7
Cpe
n
t%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794a
ed2
c
178decee1%7C0%7C0%7C636584337418853728&sdata=JZ4a9VfDppcJkfQr%2BKivd9w
GDk
U
cNHO7nDxJTXFAMus%3D&reserved=0
Pull Request
:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
om%2Fapache%2Froyale-asjs%2Fpull%2F144&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>
%7C
1
9e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
%7C
%7C636584337418853728&sdata=V%2FcBSzGeei7i0YNTIZoEnVKJbi18DtVLv%2BV%2F
2vY
7
HA4%3D&reserved=0
CloseEvent.as
Branch->mxRoyaleScrollPolicynControlBar
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleScrollPolicynControlBar&d
ata
=
02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b
5a7
b
34438794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=sWHbuXAg4aDM
ef7
%
2B56eYCTvktJzqI13HmFapcTzhcn8%3D&reserved=0
Pull Request
:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
om%2Fapache%2Froyale-asjs%2Fpull%2F145&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>
%7C
1
9e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
%7C
%7C636584337418853728&sdata=rlggrlP1C%2BlCX07dIgA2sGoIJvA%2Frc2zleh267
ZN5
N
M%3D&reserved=0
ScrollPolicy.as
ControlBar.as
Please Review.
Thanks,
Alina Kazi
-----Original Message-----
From: Alina Kazi [mailto:[email protected]<mailto:[email protected]>]
Sent: Wednesday, April 04, 2018 12:06 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Hi Alex,
Tile and Tile Direction are ready for Review.
And Now, I am working on CloseEvent.
Thanks,
Alina
-----Original Message-----
From: Alex Harui [mailto:[email protected]<mailto:[email protected]>]
Sent: Wednesday, April 04, 2018 11:14 AM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
Peter meant that the changing of mx_internal to protected was only
temporary. mx_internal should be working for Royale so please use
mx_internal instead of protected. Using protected may cause other
things to not work.
Thanks,
-Alex
From: Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To:
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Tuesday, April 3, 2018 at 10:36 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Thanks.
replaced mx_internal with protected for now.
And Tile and TileDirection are compiled Successfully without any warning.
Alina Kazi
From: Peter Ent [mailto:[email protected]<mailto:[email protected]>]
Sent: Tuesday, April 03, 2018 5:33 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
I recommended changing mx_internal to protected as a stop-gap. I knew
Alex would be putting something out for MXRoyale.
Also: please update the Github issue with your progress. I've been
trying to be consistent using it as more people working on the same
items will be confusing.
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Cpent%40adobe.co<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.co&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=xATrWRDEj0YWKchFU7LzpDNYvgNRV9ykkVLJR1KXsnY%3D&reserved=0>
m%7
C
19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C
0%7
C
0%7C636584337418853728&sdata=EhaUCaU3xuzqoQv0CnEpILTCx%2BeCa2qDuOD9Q%2
BeP
q
C8%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fissues%2F136&data=02%7C01%7Caharui%40adobe.
com
%
7
Ca8619ad543114ced36b508d599ee2969%7Cfa7b1b5a7b34438794aed2c178decee1%7
C0%
7
C
0%7C636584170597362200&sdata=5Nzq5hj1BwKn8tvGMUcb8Z6FIA0hlg2KQx%2BhpsD
RPd
c
%
3D&reserved=0>
Thanks.
Peter
From:
Piotr Zarzycki
<[email protected]<mailto:[email protected]>>
Reply-To:
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Tuesday, April 3, 2018 at 8:26 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
Hi Alina,
If it is mx_internal I see suggestion to change it to some
protected/private ? I'm not sure about that, but the other way is to
got with suggestion - create getter/setter.
Alex also in his suppress warnings in that commits [1]
[1]
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fcommit%2F3cfa84f95635df16e5f6b8214b483a&dat
a=0
2
%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a
7b3
4
438794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=6aLKAVHE6Y5iL4
OAw
8
mEHAZ5gtLABpDocDo5Jyskiqo%3D&reserved=0
e4c68a902c
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fcommit%2F3cfa84f95635df16e5f6b8214b483ae4c6
8a9
2
c&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C679c7e10e41d48c27a3908d5995e21d8%7
Cfa
7
b
1b5a7b34438794aed2c178decee1%7C0%7C0%7C636583551935678296&sdata=hUZODG
ygt
u
u
b%2BmqBixRZEd0XNL0UcTlTA0h43nGoFb0%3D&reserved=0>
Thanks,
Piotr
2018-04-03 14:22 GMT+02:00 Alina Kazi
<[email protected]<mailto:[email protected]>>:
Thanks Alex
Now I am working on : Tile and TileDirection
Both files are compiled successfully after changes Pull Request :
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C1
9
e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
7C0
%
7C636584337418853728&sdata=Q%2B%2FhMzYPx5Eklaicfgeo8p9S9EaAZfbMy6%2B0U
Xcv
b
5s%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F143&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C6
7
9
c7e10e41d48c27a3908d5995e21d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
C0%
7
C
636583551935678296&sdata=lla5d0d7ftNbP7MhPqKYHjwhn8uxAjXdHLPyGvVrTHo%3
D&r
e
s
erved=0>
Only a Warning in Tile.as
What I should do to remove that warning [java]
D:\outtest\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\
mx\containers\Tile.as(277): col: 5 public var may not work in minified
JS output . Use getter/setter instead.
[java]
[java] mx_internal var cellWidth:Number;
Thanks,
Alina Kazi
From: Alex
Harui [mailto:[email protected]<mailto:[email protected]>]
Sent: Tuesday, April 03, 2018 12:27 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
Congratulations! I merged your pull request. You have now
contributed code to Apache Royale.
You should be able to use mx_internal now. I pushed those changes
earlier.
I'm done for today, hopefully Peter or Piotr will review the
Hrule/Vrule pull request. Please make sure there are no warnings in
the build. I updated ListEvent and SliderEvent to suppress warnings.
Thanks,
-Alex
From:
Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To:
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Monday, April 2, 2018 at 11:25 PM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
Thanks alot Peter and Alex.
HRule and VRule Files are added to new Branch and Compiled
Successfully
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2Falinakazi-HRuleVRule%2Fframewor&d
ata
=
02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b
5a7
b
34438794aed2c178decee1%7C0%7C0%7C636584337418853728&sdata=KqF8DsxJLOED
LeY
D
Q4V1Jvb4KToKq43jAGIaK%2F3UbUw%3D&reserved=0
ks/projects/MXRoyale/src/main/royale/mx/controls
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2Falinakazi-HRuleVRule%2Fframeworks
%2F
p
r
ojects%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontrols&data=02%7C01%7
Cah
a
r
ui%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7Cf803a2f5bfae4b51df5508d5992bc5ff%7Cfa7b1b5a7b34438794
aed
2
c
178decee1%7C0%7C0%7C636583335664948195&sdata=0wAuwW7NcLkLbUw6yQkidChhJ
5t7
s
x
VR9aDt%2Fdqcbm0%3D&reserved=0>
In Panel : I will also replace ³mx_internal³ with "protected"
And comment-out all functions and/or variables that referencing
something not yet ported.
Alina Kazi
From: Alex
Harui [mailto:[email protected]<mailto:[email protected]>]
Sent: Monday, April 02, 2018 8:28 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Hi Alina,
mx_internal methods may not need to be ported. If they are not listed
in the list of API s you used in your app, the next question is
whether they are needed to emulate the functionality of the component
that you do use. In many cases they are not needed.
I am working on getting mx_internal working on the JS side. Even
though mx_internal APIs are not supported by Flex, I don't doubt that
other namespaces are used somewhere so we should try to get it to
work. It has been working in simple test cases so not sure yet why it
isn't working in the emulation components.
Thanks,
-Alex
From:
Peter Ent <[email protected]<mailto:[email protected]>>
Reply-To:
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Monday, April 2, 2018 at 7:06 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
Hi Alina,
Sorry for the delayed response.
First, try to port over something easier like VRule and HRule as a
first step since these are less complex.
As for mx_internal - I have been changing these to "protected".
Once you do that you'll find that you will also need IUITextField. I
haven't done that but I just took a look at it. You can do a couple
of
things:
In Panel (and any where else), comment-out any function or variable
that references something not yet ported. We are trying to pass
compilation, so that would be OK at this stage.
If you feel you need to bring something else over, then you have to go
through the same process of course. Since you can wind up following
class and interface down a long chain, I would just comment-out things
complex. Sometimes I am left with "implements IUIComponent" and the
rest of the interfaces listed in a class are put into comments.
I hope that helps.
‹peter
From:
Alina Kazi <[email protected]<mailto:[email protected]>>
Reply-To:
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: Monday, April 2, 2018 at 7:43 AM
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: RE: Work on Emulation
mx.containers.Panel
Panel.as file contains many variables and methods that are using
mx_internal e.g. Variable
mx_internal var _showCloseButton:Boolean = false;
Method
mx_internal function getStatusTextField():IUITextField
{
return statusTextField;
}
As use namespace mx_internal; and import mx.core.mx_internal; are
commented in source files .
I am getting errors on these variables and methods e.g.
[java]
D:\out\royale-asjs\frameworks\projects\MXRoyale\src\main\royale\mx\con
tai
n
e
rs\Panel.as(1796):
col: 6 function 'getStatusTextField' will be scoped to the default
namespace: mx.containers.Panel:
internal.
It will not be visible outside of this package.
[java]
[java] function getStatusTextField():IUITextField
Should I comment all of these variables and methods ?
Or
Should I make all of these variables and methods Public?
For Reference, I am sharing link. So you don't need to find this file
in flex-sdk , You can find the at:
Flex-sdk mx.containers.Panel:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.d
rop
b
ox.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fox.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=o0IG2SUHlSgYxNATHq5JyDJFTYvGrxy7ij6D5fo6L4A%3D&reserved=0>%2Fs%2F6xb1jp2efwuwnam%2FPanelFlex.as%3Fdl%3D0&data=02%7C01%7Cpe
nt%
4
0adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F0adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=2VfwjDjvNkCNplKZHSwj3a0wXKWQDCJcop9uD%2BBVfU4%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2
c17
8
decee1%7C0%7C0%7C636584337418853728&sdata=gu%2BhySrmf%2FUKFngpLQzeWcRO
CfK
e
%2FxzorPgxOHjwqis%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
dro
p
b
ox.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fox.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=o0IG2SUHlSgYxNATHq5JyDJFTYvGrxy7ij6D5fo6L4A%3D&reserved=0>%2Fs%2F6xb1jp2efwuwnam%2FPanelFlex.as%3Fdl%3D0&data=02%7C01%7Cpe
nt%
4
adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fadobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=M3lUEkvW7h4RemEKaVUqPddFeCLOUsVFEIpXN6Rc%2FFU%3D&reserved=0>%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c
178
d
e
cee1%7C0%7C0%7C636582662509500604&sdata=xLjL8AM45ZA2E8IRILbskD04cJCL9S
VSc
5
F
i0%2BO98Tg%3D&reserved=0>
Royale
:https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
om%2Falinakazi%2Froyale-asjs%2Fblob%2FmxRoyalePanel%2Fframeworks%2Fpro
&da
t
a=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b
1b5
a
7b34438794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=a8xVdkw2mn
wSo
j
xLoUJiZmOIN0SxdeqviB%2By5AbaSl4%3D&reserved=0
jects/MXRoyale/src/main/royale/mx/containers/Panel.as
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Falinakazi%2Froyale-asjs%2Fblob%2FmxRoyalePanel%2Fframeworks%2Fproj
ect
s
%
2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fcontainers%2FPanel.as&data=02%
7C0
1
%
7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b3443
879
4
a
ed2c178decee1%7C0%7C0%7C636582662509500604&sdata=Zwbl%2B2eMeQIsuoDCI4m
fZ1
A
4
TF3cA%2FcSqlzq53DEO5Y%3D&reserved=0>
Thanks in Advance.
Alina
From: Alina
Kazi [mailto:[email protected]<mailto:[email protected]>]
Sent: Monday, April 02, 2018 3:25 PM
To: [email protected]<mailto:[email protected]>
Subject: RE: Work on Emulation
Thanks
J
New branch Created :
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyalePanel&data=02%7C01%7Cpent
%40
a
dobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=bqNf4OYFIciJ0OGu%2BELGSrAnnWz6UuqA%2Bbtg6NOl3ZU%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c1
78d
e
cee1%7C0%7C0%7C636584337418863731&sdata=e43MWXidxAVYCz6uJEwPWPigWnXnlK
pgh
012hW2VmA%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyalePanel&data=02%7C01%7Cpent
%40
a
d
obe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=mtuOnFgtK%2BOTE5EgamElD3xzS64EaZ%2FCv5cYMgJ%2Fa7w%3D&reserved=0>%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c17
8de
c
e
e1%7C0%7C0%7C636582662509500604&sdata=AbVDtIurdRp7fwqDGrLxUrQqYXv8EvuT
wCD
w
7
%2BWMBtc%3D&reserved=0>
Copied MX Panel from flex-sdk to New branch (mxRoyalePanel) Pull
Request
:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F141&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C1
9
e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
7C0
%
7C636584337418863731&sdata=0%2Br4jSVY%2B3WoupxT%2BxU8noG6M3ZuN2labOIcd
B%2
F
t9%2FY%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F141&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C8
1
6
60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
C0%
7
C
636582662509500604&sdata=sVStAHTosnX0lBpTYWRCEC23BiiVaX8t1%2F08YICYjOs
%3D
&
r
eserved=0>
-Alina Kazi
From: Piotr
Zarzycki
[mailto:[email protected]<mailto:[email protected]>]
Sent: Monday, April 02, 2018 1:22 PM
To: [email protected]<mailto:[email protected]>
Subject: Re: Work on Emulation
Alina,
You cannot delete pull request. You can only close it, so we are good
with
139 and 140. They are closed.
Your pull request 138 now looks great! :)
Whenever you are going to push some bigger changes you should create
new branches. If you are working right now on Panel - probably new
branch with your changes would be the best. Our pull request will
looks than cleaner. - That is just my recommendation.
In general congrats for your first pull request to Apache Royale
project!!
:)
Thanks,
Piotr
2018-04-02 8:08 GMT+02:00 Alina Kazi
<[email protected]<mailto:[email protected]>>:
Hi Piotr,
Thanks Piotr.
I am trying to add another pull request for SliderEvent.as file. but
when I added this file manually at
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleAQ%2Fframeworks%2Fproject
&da
t
a=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b
1b5
a
7b34438794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=nQ1Yt%2FwJ
xyU
U
ybkTdCMHxgoxZ%2BaqMXv9gOJFXqo1agQ%3D&reserved=0
s
/MXRoyale/src/main/royale/mx/events
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Falinakazi%2Froyale-asjs%2Ftree%2FmxRoyaleAQ%2Fframeworks%2Fproject
s%2
5
d%250a%2FMXRoyale%2Fsrc%2Fmain%2Froyale%2Fmx%2Fevents&data=02%7C01%7Cp
ent
%
4
0adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F0adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=2VfwjDjvNkCNplKZHSwj3a0wXKWQDCJcop9uD%2BBVfU4%3D&reserved=0>%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2
c17
8
d
ecee1%7C0%7C0%7C636582662509500604&sdata=rhi6Z0g%2B6UCXr%2Btgp5gpKFrmd
aaj
q
Y
LlmTh7iNvdoCU%3D&reserved=0>
and commit it.
Commit auto added to previous Pull Request :
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F138&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C1
9
e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
7C0
%
7C636584337418863731&sdata=pqviRdd4rBRgwqPalenRjO5HljItXWOLVQXHtbvvle0
%3D
&
reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F138&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C8
1
6
60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
C0%
7
C
636582662509500604&sdata=a1%2BNp%2Ft3M7aSPIwqN%2BQt7XY50OX%2BSwRDB%2FA
CRJ
h
W
LH4%3D&reserved=0>
Is it ok to do multiple commits on same pull Request instead of
creating New Pull Request for each file?
How Can I delete these Closed Pull Requests?
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F139&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C1
9
e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
7C0
%
7C636584337418863731&sdata=O%2BQydj0NU08TgdGr8jlB%2B5XAWpOm43BMhggA6O7
OlL
Q
%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F139&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C8
1
6
60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
C0%
7
C
636582662509500604&sdata=apy1DAJqmHGIjCdQDz4g0K36NbZATtHhA%2Foqc659Bjs
%3D
&
r
eserved=0>
and
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F140&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C1
9
e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
7C0
%
7C636584337418863731&sdata=6eljm%2FuiMELY9NLSm3lt9mV3%2BfInbFfsAWuo4ZZ
UMS
M
%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F140&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%
7C8
1
6
60be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7
C0%
7
C
636582662509500604&sdata=XehX29ItsGAwo33xue7KI9uD4PEJS3gGhS7ad1E7iSk%3
D&r
e
s
erved=0>
-Alina
-----Original Message-----
From: piotrz [mailto:[email protected]<mailto:[email protected]>]
Sent: Friday, March 30, 2018 5:14 PM
To:
[email protected]<mailto:[email protected]>
<mailto:[email protected]<mailto:[email protected]>>
Subject: Re: Work on Emulation
I see your new pull request and it doesn't looks good. [1] As you can
see on the screenshot you did it against develop from feature/MXRoyale
and it contains 94 commits.
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach
e-r
o
yale-users.20374.n8.nabble.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fyale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=%2FT3CFWQA8u%2FTtdoVjkJVW%2B4wuugGWthAJ5FpGnGYQPc%3D&reserved=0>%2Ffile%2Ft1%2Fnew_pull_request.pn<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Frequest.pn&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=N%2Bsq%2BVUX6VTSXkFaQvVHy%2FNTVpj6YjrtXoOY82Qrabo%3D&reserved=0>&data=
02%
7
C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b
344
3
8794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=rHNZfTbTa2Z8iLXt
slP
o
gffyHAy%2B76ZnN7AgZytmsSw%3D&reserved=0
g
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach
e-r
o
y
ale-users.20374.n8.nabble.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0>%2Ffile%2Ft1%2Fnew_pull_request.png&data=
02%
7
C
01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b3
443
8
7
94aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=O0UU8UF57g%2BxBjEm
1BU
%
2
BDdoyAqaNEMxwl%2FQijXxEDKQ%3D&reserved=0>
The old one is being done correctly. You have used your branch ->
apache:feature/MXRoyale from alinakazi:mxRoyaleAQ
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach
e-r
o
yale-users.20374.n8.nabble.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fyale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=%2FT3CFWQA8u%2FTtdoVjkJVW%2B4wuugGWthAJ5FpGnGYQPc%3D&reserved=0>%2Ffile%2Ft1%2Fold_pull_Request.pn<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fest.pn&data=02%7C01%7Caharui%40adobe.com%7C17e2809e7c5a494da4d808d5a4a6520e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636595956649829809&sdata=4IjQ%2B32FDz3E41Oj0WhBME7zmTGNzzSKxw4GIlHfwd0%3D&reserved=0>&data=
02%
7
C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b
344
3
8794aed2c178decee1%7C0%7C0%7C636584337418863731&sdata=Q1RLtZlGQgzJ3ZIG
Y3I
P
zf168%2BcwK2RY5I4agLcLnK0%3D&reserved=0
g
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach
e-r
o
y
ale-users.20374.n8.nabble.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0>%2Ffile%2Ft1%2Fold_pull_Request.png&data=
02%
7
C
01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b3
443
8
7
94aed2c178decee1%7C0%7C0%7C636582662509500604&sdata=wY1dxwYu%2B2G%2Be3
czh
r
a
yFYw7FGgBmQIqic7v26mzqEk%3D&reserved=0>
[1]
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
b.c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F139%2Fcommits&data=02%7C01%7Cpent%40
ado
b
e.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=aJFV4y7TXpbfAMLAbQpO%2FTO4cPiJ5hWMYGisG%2Fr9FJc%3D&reserved=0>%7C19e6271d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178d
ece
e
1%7C0%7C0%7C636584337418863731&sdata=T002sFfbImGVBpkSiCiHDrfobQS9vAhgE
nZ4
i
jOJq9A%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.
c
o
m%2Fapache%2Froyale-asjs%2Fpull%2F139%2Fcommits&data=02%7C01%7Cpent%40
ado
b
e
.com%7C81660be1d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178de
cee
1
%
7C0%7C0%7C636582662509500604&sdata=HUrVPryVBIrheFbS%2BzRap%2BPpOrVETRJ
B%2
F
h
630nCVWPo%3D&reserved=0>
Thanks,
Piotr
--
Sent from:
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache
-ro
y
ale-users.20374.n8.nabble.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0>%2F&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e
627
1
d08cd4b9abe1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7
C63
6
584337418863731&sdata=HZlkRMQseCJzWNErp9aIFkPVDXSfLN1wJgcwLdil%2FT4%3D
&re
s
erved=0
<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapach
e-r
o
y
ale-users.20374.n8.nabble.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fale-users.20374.n8.nabble.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=kQDZN2LR2HoCcGIlhZm%2BGGwf4ldcFJhSkusV1v%2Bj1fY%3D&reserved=0>%2F&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C816
60b
e
1
d8504effc16c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C
636
5
8
2662509500604&sdata=pfDAW81u489DuWy0Gc80ll1HzseZk5gMhoneBuYpCJQ%3D&res
erv
e
d
=0>
--
Piotr Zarzycki
Patreon:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
atr
e
on.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4
b9a
b
e1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636584337
418
8
63731&sdata=%2BKhmm2BcQez99eBDaV5OOy%2BzAbRWku6eP318jSrVAAU%3D&reserve
d=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
pat
r
e
on.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C81660be1d8504
eff
c
1
6c08d5988f0c53%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365826625
095
604&sdata=7xFAD19Wk39S%2BJEn6QB6jibV8%2B7Y9O8Ee16CAVyZPTk%3D&reserved=
0>
--
Piotr Zarzycki
Patreon:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
atr
e
on.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C19e6271d08cd4
b9a
b
e1908d59a1502c5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636584337
418
8
63731&sdata=%2BKhmm2BcQez99eBDaV5OOy%2BzAbRWku6eP318jSrVAAU%3D&reserve
d=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
pat
r
e
on.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fon.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=r8DOztOKJYlPuLlxBxJmA%2Fjaz9yQidB9Ucdt0JH1fyI%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2F40adobe.com&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=BOlmdD4BAIE7tS67mehcEb2jP8vdh1S885zO9OBIQqs%3D&reserved=0>%7C679c7e10e41d4
8c2
7
a
3908d5995e21d8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6365835519
356
7
8
296&sdata=ouHh9HJGSsN0f2%2B7vw5GDz2bcplJFMmO1DDodVy9%2BNo%3D&reserved=
0>
--
Piotr Zarzycki
Patreon:
https://www.patreon.com/piotrzarzycki<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Cpent%40adobe.com%7Cae87b81b8bb84d66366908d59bad26de%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636586090342823354&sdata=Ck9yLwxMUCVN9L8oeAhHKKaPOHYHY0x6qFa6zn4hfMk%3D&reserved=0>
