Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: [PATCH 5/5 v2] rt2x00: Avoid unnecessary uncached reads
in rt2800pci (Gertjan van Wingerde)
2. Status of rt539x support? (Sonny Piers)
----------------------------------------------------------------------
Message: 1
Date: Sat, 3 Sep 2011 20:42:20 -0700
From: Gertjan van Wingerde <[email protected]>
To: Helmut Schaa <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH 5/5 v2] rt2x00: Avoid unnecessary
uncached reads in rt2800pci
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 2 sep. 2011, at 01:10, Helmut Schaa <[email protected]> wrote:
> Reading the TX desciptor words from coherent memory is always uncached
> and potentially slow. Hence, don't read the TX descriptor prior to
> writing it since we update all fields anyway.
>
> Signed-off-by: Helmut Schaa <[email protected]>
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
>
> v2: Initialize word to zero for readability reasons ...
>
> drivers/net/wireless/rt2x00/rt2800pci.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
> b/drivers/net/wireless/rt2x00/rt2800pci.c
> index 2633628..e0493fb 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -619,11 +619,11 @@ static void rt2800pci_write_tx_desc(struct queue_entry
> *entry,
> /*
> * Initialize TX descriptor
> */
> - rt2x00_desc_read(txd, 0, &word);
> + word = 0;
> rt2x00_set_field32(&word, TXD_W0_SD_PTR0, skbdesc->skb_dma);
> rt2x00_desc_write(txd, 0, word);
>
> - rt2x00_desc_read(txd, 1, &word);
> + word = 0;
> rt2x00_set_field32(&word, TXD_W1_SD_LEN1, entry->skb->len);
> rt2x00_set_field32(&word, TXD_W1_LAST_SEC1,
> !test_bit(ENTRY_TXD_MORE_FRAG, &txdesc->flags));
> @@ -634,12 +634,12 @@ static void rt2800pci_write_tx_desc(struct queue_entry
> *entry,
> rt2x00_set_field32(&word, TXD_W1_DMA_DONE, 0);
> rt2x00_desc_write(txd, 1, word);
>
> - rt2x00_desc_read(txd, 2, &word);
> + word = 0;
> rt2x00_set_field32(&word, TXD_W2_SD_PTR1,
> skbdesc->skb_dma + TXWI_DESC_SIZE);
> rt2x00_desc_write(txd, 2, word);
>
> - rt2x00_desc_read(txd, 3, &word);
> + word = 0;
> rt2x00_set_field32(&word, TXD_W3_WIV,
> !test_bit(ENTRY_TXD_ENCRYPT_IV, &txdesc->flags));
> rt2x00_set_field32(&word, TXD_W3_QSEL, 2);
> --
> 1.7.3.4
>
>
> _______________________________________________
> users mailing list
> [email protected]
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
Message: 2
Date: Sun, 04 Sep 2011 17:05:48 +0200
From: Sonny Piers <[email protected]>
To: [email protected]
Subject: [rt2x00-users] Status of rt539x support?
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Hello,
I wonder what is the status of rt539x support.
I have read few months ago it was experimental, still the case?
I have tried rt2x00 with my rt5390 chipset the card is well-recognize
and the modules are correctly loaded by udev. However I get constantly
disconnected and sometimes it fails to scan.
For the moment I use the driver from ralink but I would love replace it
with rt2x00.
Cheers.
Sonny Piers.
------------------------------
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
End of users Digest, Vol 31, Issue 5
************************************
