Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: [PATCH] rt2x00: print chip and firmware version by
default (Gertjan van Wingerde)
----------------------------------------------------------------------
Message: 1
Date: Wed, 23 Jan 2013 19:03:30 +0100
From: Gertjan van Wingerde <[email protected]>
To: Stanislaw Gruszka <[email protected]>
Cc: "[email protected]" <[email protected]>,
Xose Vazquez Perez <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: print chip and firmware
version by default
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi Stanislaw,
Sent from my iPad
On 22 jan. 2013, at 23:19, Stanislaw Gruszka <[email protected]> wrote:
> On Tue, Jan 22, 2013 at 10:12:32PM +0100, Xose Vazquez Perez wrote:
>> On 01/22/2013 07:58 PM, Gertjan van Wingerde wrote:
>>
>>> On 22 jan. 2013, at 17:49, Stanislaw Gruszka <[email protected]> wrote:
>>>
>>>> Signed-off-by: Stanislaw Gruszka <[email protected]>
>>>> Tested-by: Xose Vazquez Perez <[email protected]>
>>>> ---
>>>> drivers/net/wireless/rt2x00/rt2x00.h | 2 +-
>>>> drivers/net/wireless/rt2x00/rt2x00mac.c | 6 +++---
>>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
>>>> b/drivers/net/wireless/rt2x00/rt2x00.h
>>>> index 3e37c19..bef449c 100644
>>>> --- a/drivers/net/wireless/rt2x00/rt2x00.h
>>>> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
>>>> @@ -92,7 +92,7 @@
>>>> #define NOTICE(__dev, __msg, __args...) \
>>>> DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
>>>> #define INFO(__dev, __msg, __args...) \
>>>> - DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args)
>>>> + DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
>>>> #define DEBUG(__dev, __msg, __args...) \
>>>> DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args)
>>>> #define EEPROM(__dev, __msg, __args...) \
>>
>>> I think this change is good, but we should also change WARNING and
>>> NOTICE. Otherwise they won't be displayed if CONFIG_RT2X00_DEBUG is
>>> disabled, but INFO will, which would be strange.
>
> We have those "TX status report missed" messages which spam logs,
> I think we should move them to DEBUG level then.
>
> NOTICE is only used in suspend/resume, it should be DEBUG too and NOTICE
> macro could be removed.
>
>> I believe this patch is so useful and trivial enough to be included,
>> as is, in the next 3.8-rc .
>>
>> The next steps can be done for 3.9
>
> If Gertjan will be so kind and ACK this patch, I'll post further
> changes as incremental patch :-)
As I mentioned to Xose already yesterday, I think this is only appropriate for
-next, so we can do this properly. I can see this being handled as a series of
patches, which first change the loglevels of the existing log lines, then
remove NOTICE, and them change the macro of WARNING to not be covered by
CONFIG_RT2X00_DEBUG.
---
Gertjan
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 47, Issue 20
*************************************
