Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. [PATCH 1/4] rt2x00: print warning, notice and info as default
(Stanislaw Gruszka)
2. [PATCH 2/4] rt2x00: remove NOTICE (Stanislaw Gruszka)
3. [PATCH 3/4] rt2800usb: move "TX status missed" messages to
debug level (Stanislaw Gruszka)
4. [PATCH 4/4] rt2x00: print queue parameters at debug level
(Stanislaw Gruszka)
5. Re: [PATCH 1/4] rt2x00: print warning, notice and info as
default (Gertjan van Wingerde)
6. Re: [PATCH 2/4] rt2x00: remove NOTICE (Gertjan van Wingerde)
7. Re: [PATCH 3/4] rt2800usb: move "TX status missed" messages
to debug level (Gertjan van Wingerde)
8. Re: [PATCH 4/4] rt2x00: print queue parameters at debug level
(Gertjan van Wingerde)
----------------------------------------------------------------------
Message: 1
Date: Thu, 24 Jan 2013 21:59:32 +0100
From: Stanislaw Gruszka <[email protected]>
To: "John W. Linville" <[email protected]>
Cc: [email protected], Xose Vazquez Perez
<[email protected]>, [email protected]
Subject: [rt2x00-users] [PATCH 1/4] rt2x00: print warning, notice and
info as default
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Some messages provide useful information, but are disabled without
CONFIG_RT2X00_DEBUG=y, so enable them by default
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
b/drivers/net/wireless/rt2x00/rt2x00.h
index 3e37c19..8ef11b6 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h
@@ -88,11 +88,11 @@
#define ERROR_PROBE(__msg, __args...) \
DEBUG_PRINTK_PROBE(KERN_ERR, "Error", __msg, ##__args)
#define WARNING(__dev, __msg, __args...) \
- DEBUG_PRINTK(__dev, KERN_WARNING, "Warning", __msg, ##__args)
+ DEBUG_PRINTK_MSG(__dev, KERN_WARNING, "Warning", __msg, ##__args)
#define NOTICE(__dev, __msg, __args...) \
- DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
+ DEBUG_PRINTK_MSG(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
#define INFO(__dev, __msg, __args...) \
- DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args)
+ DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
#define DEBUG(__dev, __msg, __args...) \
DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args)
#define EEPROM(__dev, __msg, __args...) \
--
1.7.4.4
------------------------------
Message: 2
Date: Thu, 24 Jan 2013 22:00:28 +0100
From: Stanislaw Gruszka <[email protected]>
To: "John W. Linville" <[email protected]>
Cc: [email protected], Xose Vazquez Perez
<[email protected]>, [email protected]
Subject: [rt2x00-users] [PATCH 2/4] rt2x00: remove NOTICE
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
We use this macro only on 3 places - remove it and replace by other
appropriate macros for printing messages.
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
drivers/net/wireless/rt2x00/rt2x00.h | 2 --
drivers/net/wireless/rt2x00/rt2x00dev.c | 4 ++--
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
b/drivers/net/wireless/rt2x00/rt2800lib.c
index a1de95e..1791260 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -80,7 +80,7 @@ static inline bool rt2800_is_305x_soc(struct rt2x00_dev
*rt2x00dev)
rt2x00_rf(rt2x00dev, RF3022))
return true;
- NOTICE(rt2x00dev, "Unknown RF chipset on rt305x\n");
+ INFO(rt2x00dev, "Unknown RF chipset on rt305x\n");
return false;
}
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
b/drivers/net/wireless/rt2x00/rt2x00.h
index 8ef11b6..ad73942 100644
--- a/drivers/net/wireless/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/rt2x00/rt2x00.h
@@ -89,8 +89,6 @@
DEBUG_PRINTK_PROBE(KERN_ERR, "Error", __msg, ##__args)
#define WARNING(__dev, __msg, __args...) \
DEBUG_PRINTK_MSG(__dev, KERN_WARNING, "Warning", __msg, ##__args)
-#define NOTICE(__dev, __msg, __args...) \
- DEBUG_PRINTK_MSG(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
#define INFO(__dev, __msg, __args...) \
DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
#define DEBUG(__dev, __msg, __args...) \
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c
b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 96fffe8..07a9e10 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -1440,7 +1440,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
#ifdef CONFIG_PM
int rt2x00lib_suspend(struct rt2x00_dev *rt2x00dev, pm_message_t state)
{
- NOTICE(rt2x00dev, "Going to sleep.\n");
+ DEBUG(rt2x00dev, "Going to sleep.\n");
/*
* Prevent mac80211 from accessing driver while suspended.
@@ -1480,7 +1480,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_suspend);
int rt2x00lib_resume(struct rt2x00_dev *rt2x00dev)
{
- NOTICE(rt2x00dev, "Waking up.\n");
+ DEBUG(rt2x00dev, "Waking up.\n");
/*
* Restore/enable extra components.
--
1.7.4.4
------------------------------
Message: 3
Date: Thu, 24 Jan 2013 22:01:10 +0100
From: Stanislaw Gruszka <[email protected]>
To: "John W. Linville" <[email protected]>
Cc: [email protected], Xose Vazquez Perez
<[email protected]>, [email protected]
Subject: [rt2x00-users] [PATCH 3/4] rt2800usb: move "TX status missed"
messages to debug level
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Those messages can flood in dmesg, so do not print them by default.
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/rt2x00/rt2800usb.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
b/drivers/net/wireless/rt2x00/rt2800usb.c
index 011410f..047ead5 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -540,9 +540,9 @@ rt2800usb_txdone_entry_check(struct queue_entry *entry, u32
reg)
tx_pid = rt2x00_get_field32(word, TXWI_W1_PACKETID);
if (wcid != tx_wcid || ack != tx_ack || (!is_agg && pid != tx_pid)) {
- WARNING(entry->queue->rt2x00dev,
- "TX status report missed for queue %d entry %d\n",
- entry->queue->qid, entry->entry_idx);
+ DEBUG(entry->queue->rt2x00dev,
+ "TX status report missed for queue %d entry %d\n",
+ entry->queue->qid, entry->entry_idx);
return TXDONE_UNKNOWN;
}
--
1.7.4.4
------------------------------
Message: 4
Date: Thu, 24 Jan 2013 22:01:55 +0100
From: Stanislaw Gruszka <[email protected]>
To: "John W. Linville" <[email protected]>
Cc: [email protected], Xose Vazquez Perez
<[email protected]>, [email protected]
Subject: [rt2x00-users] [PATCH 4/4] rt2x00: print queue parameters at
debug level
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Those messages do not provide interesting information for average user,
print them at debug level.
Signed-off-by: Stanislaw Gruszka <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00mac.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c
b/drivers/net/wireless/rt2x00/rt2x00mac.c
index ed7a1bb..20c6ecc 100644
--- a/drivers/net/wireless/rt2x00/rt2x00mac.c
+++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
@@ -731,9 +731,9 @@ int rt2x00mac_conf_tx(struct ieee80211_hw *hw,
queue->aifs = params->aifs;
queue->txop = params->txop;
- INFO(rt2x00dev,
- "Configured TX queue %d - CWmin: %d, CWmax: %d, Aifs: %d, TXop:
%d.\n",
- queue_idx, queue->cw_min, queue->cw_max, queue->aifs, queue->txop);
+ DEBUG(rt2x00dev,
+ "Configured TX queue %d - CWmin: %d, CWmax: %d, Aifs: %d, TXop:
%d.\n",
+ queue_idx, queue->cw_min, queue->cw_max, queue->aifs,
queue->txop);
return 0;
}
--
1.7.4.4
------------------------------
Message: 5
Date: Thu, 24 Jan 2013 22:06:07 +0100
From: Gertjan van Wingerde <[email protected]>
To: Stanislaw Gruszka <[email protected]>
Cc: "[email protected]" <[email protected]>,
Xose Vazquez Perez <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH 1/4] rt2x00: print warning, notice
and info as default
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 24 jan. 2013, at 21:59, Stanislaw Gruszka <[email protected]> wrote:
> Some messages provide useful information, but are disabled without
> CONFIG_RT2X00_DEBUG=y, so enable them by default
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
Acked-by: Gertjan van Wingerde <[email protected]>
Thanks for respinning.
> ---
> drivers/net/wireless/rt2x00/rt2x00.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
> b/drivers/net/wireless/rt2x00/rt2x00.h
> index 3e37c19..8ef11b6 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> @@ -88,11 +88,11 @@
> #define ERROR_PROBE(__msg, __args...) \
> DEBUG_PRINTK_PROBE(KERN_ERR, "Error", __msg, ##__args)
> #define WARNING(__dev, __msg, __args...) \
> - DEBUG_PRINTK(__dev, KERN_WARNING, "Warning", __msg, ##__args)
> + DEBUG_PRINTK_MSG(__dev, KERN_WARNING, "Warning", __msg, ##__args)
> #define NOTICE(__dev, __msg, __args...) \
> - DEBUG_PRINTK(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
> + DEBUG_PRINTK_MSG(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
> #define INFO(__dev, __msg, __args...) \
> - DEBUG_PRINTK(__dev, KERN_INFO, "Info", __msg, ##__args)
> + DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
> #define DEBUG(__dev, __msg, __args...) \
> DEBUG_PRINTK(__dev, KERN_DEBUG, "Debug", __msg, ##__args)
> #define EEPROM(__dev, __msg, __args...) \
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Message: 6
Date: Thu, 24 Jan 2013 22:06:48 +0100
From: Gertjan van Wingerde <[email protected]>
To: Stanislaw Gruszka <[email protected]>
Cc: "[email protected]" <[email protected]>,
Xose Vazquez Perez <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH 2/4] rt2x00: remove NOTICE
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 24 jan. 2013, at 22:00, Stanislaw Gruszka <[email protected]> wrote:
> We use this macro only on 3 places - remove it and replace by other
> appropriate macros for printing messages.
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
> drivers/net/wireless/rt2x00/rt2x00.h | 2 --
> drivers/net/wireless/rt2x00/rt2x00dev.c | 4 ++--
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c
> b/drivers/net/wireless/rt2x00/rt2800lib.c
> index a1de95e..1791260 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -80,7 +80,7 @@ static inline bool rt2800_is_305x_soc(struct rt2x00_dev
> *rt2x00dev)
> rt2x00_rf(rt2x00dev, RF3022))
> return true;
>
> - NOTICE(rt2x00dev, "Unknown RF chipset on rt305x\n");
> + INFO(rt2x00dev, "Unknown RF chipset on rt305x\n");
> return false;
> }
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
> b/drivers/net/wireless/rt2x00/rt2x00.h
> index 8ef11b6..ad73942 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> @@ -89,8 +89,6 @@
> DEBUG_PRINTK_PROBE(KERN_ERR, "Error", __msg, ##__args)
> #define WARNING(__dev, __msg, __args...) \
> DEBUG_PRINTK_MSG(__dev, KERN_WARNING, "Warning", __msg, ##__args)
> -#define NOTICE(__dev, __msg, __args...) \
> - DEBUG_PRINTK_MSG(__dev, KERN_NOTICE, "Notice", __msg, ##__args)
> #define INFO(__dev, __msg, __args...) \
> DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args)
> #define DEBUG(__dev, __msg, __args...) \
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c
> b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 96fffe8..07a9e10 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1440,7 +1440,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
> #ifdef CONFIG_PM
> int rt2x00lib_suspend(struct rt2x00_dev *rt2x00dev, pm_message_t state)
> {
> - NOTICE(rt2x00dev, "Going to sleep.\n");
> + DEBUG(rt2x00dev, "Going to sleep.\n");
>
> /*
> * Prevent mac80211 from accessing driver while suspended.
> @@ -1480,7 +1480,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_suspend);
>
> int rt2x00lib_resume(struct rt2x00_dev *rt2x00dev)
> {
> - NOTICE(rt2x00dev, "Waking up.\n");
> + DEBUG(rt2x00dev, "Waking up.\n");
>
> /*
> * Restore/enable extra components.
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Message: 7
Date: Thu, 24 Jan 2013 22:07:06 +0100
From: Gertjan van Wingerde <[email protected]>
To: Stanislaw Gruszka <[email protected]>
Cc: "[email protected]" <[email protected]>,
Xose Vazquez Perez <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH 3/4] rt2800usb: move "TX status
missed" messages to debug level
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 24 jan. 2013, at 22:01, Stanislaw Gruszka <[email protected]> wrote:
> Those messages can flood in dmesg, so do not print them by default.
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt2800usb.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
> b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 011410f..047ead5 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -540,9 +540,9 @@ rt2800usb_txdone_entry_check(struct queue_entry *entry,
> u32 reg)
> tx_pid = rt2x00_get_field32(word, TXWI_W1_PACKETID);
>
> if (wcid != tx_wcid || ack != tx_ack || (!is_agg && pid != tx_pid)) {
> - WARNING(entry->queue->rt2x00dev,
> - "TX status report missed for queue %d entry %d\n",
> - entry->queue->qid, entry->entry_idx);
> + DEBUG(entry->queue->rt2x00dev,
> + "TX status report missed for queue %d entry %d\n",
> + entry->queue->qid, entry->entry_idx);
> return TXDONE_UNKNOWN;
> }
>
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Message: 8
Date: Thu, 24 Jan 2013 22:07:28 +0100
From: Gertjan van Wingerde <[email protected]>
To: Stanislaw Gruszka <[email protected]>
Cc: "[email protected]" <[email protected]>,
Xose Vazquez Perez <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH 4/4] rt2x00: print queue parameters
at debug level
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 24 jan. 2013, at 22:01, Stanislaw Gruszka <[email protected]> wrote:
> Those messages do not provide interesting information for average user,
> print them at debug level.
>
> Signed-off-by: Stanislaw Gruszka <[email protected]>
Acked-by: Gertjan van Wingerde <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt2x00mac.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c
> b/drivers/net/wireless/rt2x00/rt2x00mac.c
> index ed7a1bb..20c6ecc 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00mac.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c
> @@ -731,9 +731,9 @@ int rt2x00mac_conf_tx(struct ieee80211_hw *hw,
> queue->aifs = params->aifs;
> queue->txop = params->txop;
>
> - INFO(rt2x00dev,
> - "Configured TX queue %d - CWmin: %d, CWmax: %d, Aifs: %d, TXop:
> %d.\n",
> - queue_idx, queue->cw_min, queue->cw_max, queue->aifs, queue->txop);
> + DEBUG(rt2x00dev,
> + "Configured TX queue %d - CWmin: %d, CWmax: %d, Aifs: %d, TXop:
> %d.\n",
> + queue_idx, queue->cw_min, queue->cw_max, queue->aifs, queue->txop);
>
> return 0;
> }
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 47, Issue 21
*************************************
