Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. [PATCH] rt2x00: make the driver build for Ralink SoC
(John Crispin)
2. Re: [PATCH] rt2x00: make the driver build for Ralink SoC
(Gertjan van Wingerde)
----------------------------------------------------------------------
Message: 1
Date: Wed, 20 Mar 2013 20:48:35 +0100
From: John Crispin <[email protected]>
To: "John W. Linville" <[email protected]>
Cc: [email protected], [email protected],
John Crispin <[email protected]>
Subject: [rt2x00-users] [PATCH] rt2x00: make the driver build for
Ralink SoC
Message-ID: <[email protected]>
Fix up the dependencies to make the driver actually compile on Ralink WiSoC.
Signed-off-by: John Crispin <[email protected]>
---
drivers/net/wireless/rt2x00/Kconfig | 2 +-
drivers/net/wireless/rt2x00/rt2x00pci.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rt2x00/Kconfig
b/drivers/net/wireless/rt2x00/Kconfig
index 2bf4efa..dc7ee6c 100644
--- a/drivers/net/wireless/rt2x00/Kconfig
+++ b/drivers/net/wireless/rt2x00/Kconfig
@@ -57,7 +57,7 @@ config RT2800PCI
tristate "Ralink rt27xx/rt28xx/rt30xx (PCI/PCIe/PCMCIA) support"
depends on PCI || SOC_RT288X || SOC_RT305X
select RT2800_LIB
- select RT2X00_LIB_PCI if PCI
+ select RT2X00_LIB_PCI
select RT2X00_LIB_SOC if SOC_RT288X || SOC_RT305X
select RT2X00_LIB_FIRMWARE
select RT2X00_LIB_CRYPTO
diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c
b/drivers/net/wireless/rt2x00/rt2x00pci.c
index a0c8cae..fa20add 100644
--- a/drivers/net/wireless/rt2x00/rt2x00pci.c
+++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
@@ -208,6 +208,7 @@ void rt2x00pci_uninitialize(struct rt2x00_dev *rt2x00dev)
}
EXPORT_SYMBOL_GPL(rt2x00pci_uninitialize);
+#ifdef CONFIG_PCI
/*
* PCI driver handlers.
*/
@@ -392,6 +393,7 @@ int rt2x00pci_resume(struct pci_dev *pci_dev)
}
EXPORT_SYMBOL_GPL(rt2x00pci_resume);
#endif /* CONFIG_PM */
+#endif /* CONFIG_PCI */
/*
* rt2x00pci module information.
--
1.7.10.4
------------------------------
Message: 2
Date: Wed, 20 Mar 2013 22:29:31 +0100
From: Gertjan van Wingerde <[email protected]>
To: John Crispin <[email protected]>
Cc: John Crispin <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: make the driver build for
Ralink SoC
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Sent from my iPad
On 20 mrt. 2013, at 20:48, John Crispin <[email protected]> wrote:
> Fix up the dependencies to make the driver actually compile on Ralink WiSoC.
>
> Signed-off-by: John Crispin <[email protected]>
I don't think this is a proper way to handle this. rt2x00pci.c was only meant
to be used for PCI devices; introducing the use of CONFIG_PCI in that file
doesn't seem appropriate to me.
Unfortunately I am away from my home computer, so I can't look at this properly
until the weekend.
> ---
> drivers/net/wireless/rt2x00/Kconfig | 2 +-
> drivers/net/wireless/rt2x00/rt2x00pci.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rt2x00/Kconfig
> b/drivers/net/wireless/rt2x00/Kconfig
> index 2bf4efa..dc7ee6c 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -57,7 +57,7 @@ config RT2800PCI
> tristate "Ralink rt27xx/rt28xx/rt30xx (PCI/PCIe/PCMCIA) support"
> depends on PCI || SOC_RT288X || SOC_RT305X
> select RT2800_LIB
> - select RT2X00_LIB_PCI if PCI
> + select RT2X00_LIB_PCI
> select RT2X00_LIB_SOC if SOC_RT288X || SOC_RT305X
> select RT2X00_LIB_FIRMWARE
> select RT2X00_LIB_CRYPTO
> diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c
> b/drivers/net/wireless/rt2x00/rt2x00pci.c
> index a0c8cae..fa20add 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
> @@ -208,6 +208,7 @@ void rt2x00pci_uninitialize(struct rt2x00_dev *rt2x00dev)
> }
> EXPORT_SYMBOL_GPL(rt2x00pci_uninitialize);
>
> +#ifdef CONFIG_PCI
> /*
> * PCI driver handlers.
> */
> @@ -392,6 +393,7 @@ int rt2x00pci_resume(struct pci_dev *pci_dev)
> }
> EXPORT_SYMBOL_GPL(rt2x00pci_resume);
> #endif /* CONFIG_PM */
> +#endif /* CONFIG_PCI */
>
> /*
> * rt2x00pci module information.
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 49, Issue 22
*************************************
