Send users mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of users digest..."
Today's Topics:
1. Re: rt2800: add experimental support for 5592 chip (Gregor Larson)
2. Re: [PATCH] rt2x00: make the driver build for Ralink SoC
(John Crispin)
3. Re: [PATCH] rt2x00: make the driver build for Ralink SoC
(Gabor Juhos)
4. Re: rt2800: add experimental support for 5592 chip
(Stanislaw Gruszka)
----------------------------------------------------------------------
Message: 1
Date: Wed, 20 Mar 2013 23:36:50 -0400
From: Gregor Larson <[email protected]>
To: [email protected]
Subject: Re: [rt2x00-users] rt2800: add experimental support for 5592
chip
Message-ID:
<CANYZgqsFg-UoCNHsK=4k5uCJ2PJ=wwbrc6mb8jmgsjzmj5c...@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Stanislaw,
I ported your patches (Mar 17) back to 3.8 and did some testing with a
D-Link DWA-160 Ver.B2 USB adapter.
I was able to get the client mode connecting with 2.4GHz or 5GHz, to a
D-Link DIR-835-A1 access point.
No luck configuring the DWA-160 in AP mode (hostapd) so far. The
client I tested with always dropped after DHCP.
I will try again with a different client.
I had a question about the change:
In rt2800lib.c function rt2800_init_rfcsr:
switch (rt2x00dev->chip.rt) {
...
case RT5592:
rt2800_init_rfcsr_5592(rt2x00dev);
return 0; // why return 0 just for RT5592?
}
Later, in the function there are more references to
REV_RT5592C and RT5592, so should the return 0; really be break; ?
- Greg
------------------------------
Message: 2
Date: Thu, 21 Mar 2013 08:35:34 +0100
From: John Crispin <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: make the driver build for
Ralink SoC
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>> Fix up the dependencies to make the driver actually compile on Ralink WiSoC.
>>
>> Signed-off-by: John Crispin<[email protected]>
> I don't think this is a proper way to handle this. rt2x00pci.c was only meant
> to be used for PCI devices; introducing the use of CONFIG_PCI in that file
> doesn't seem appropriate to me.
>
> Unfortunately I am away from my home computer, so I can't look at this
> properly until the weekend.
>
Indeed not the cleanest patch ... after changing the config symbols I
realized that that is not enough to make the driver actually work
It turns out that inside openwrt the compat-wireless package sets
CONFIG_RT2800PCI=m to make the driver build and then applies the
#ifdef'ery to rt2880pci.c
I will try to find the time today or tomorrow to have a closer look at this
John
------------------------------
Message: 3
Date: Thu, 21 Mar 2013 19:03:30 +0100
From: Gabor Juhos <[email protected]>
To: Gertjan van Wingerde <[email protected]>
Cc: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>,
John Crispin <[email protected]>
Subject: Re: [rt2x00-users] [PATCH] rt2x00: make the driver build for
Ralink SoC
Message-ID: <[email protected]>
Content-Type: text/plain; charset=ISO-8859-1
2013.03.20. 22:29 keltez?ssel, Gertjan van Wingerde ?rta:
>
>
> Sent from my iPad
>
> On 20 mrt. 2013, at 20:48, John Crispin <[email protected]> wrote:
>
>> Fix up the dependencies to make the driver actually compile on Ralink WiSoC.
>>
>> Signed-off-by: John Crispin <[email protected]>
>
> I don't think this is a proper way to handle this. rt2x00pci.c was only
> meant to be used for PCI devices; introducing the use of CONFIG_PCI in that
> file
> doesn't seem appropriate to me.
Well, CONFIG_PCI is also used in rt2800pci.c. The root cause of the problem is
that rt2800pci (despite its name) is used to drive the built-in wireless MAC of
various SoCs. This is because handling of the PCI and of the SoC built-in
devices is quite similar. However regardless of the underlying bus type,
rt2800pci uses several functions exported from rt2x00pci so it should always
select RT2X00_LIB_PCI.
The rt2x00pci_{probe,remove,suspend,resume} handlers from rt2x00pci are not used
by rt2800pci if PCI disabled. However the presence of that functions in rt2x00
causes build error if the driver is compiled with disabled PCI support.
If we properly want to fix the issue, lots of functions should be renamed and
should be moved into separate modules. The name of these new modules could be
rt2x00mmio and rt2800mmio for example.
Adding CONFIG_PCI to rt2x00pci could be a temporary solution until that is not
done.
-Gabor
------------------------------
Message: 4
Date: Thu, 21 Mar 2013 20:26:19 +0100
From: Stanislaw Gruszka <[email protected]>
To: Gregor Larson <[email protected]>
Cc: [email protected]
Subject: Re: [rt2x00-users] rt2800: add experimental support for 5592
chip
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
On Wed, Mar 20, 2013 at 11:36:50PM -0400, Gregor Larson wrote:
> I had a question about the change:
>
> In rt2800lib.c function rt2800_init_rfcsr:
> switch (rt2x00dev->chip.rt) {
> ...
> case RT5592:
> rt2800_init_rfcsr_5592(rt2x00dev);
> return 0; // why return 0 just for RT5592?
> }
>
> Later, in the function there are more references to
> REV_RT5592C and RT5592, so should the return 0; really be break; ?
No, I added all code that program 5592 registers below to
rt2800_init_rfcsr_5592(), just didn't cleanup. Those cleanup patches are
on the way ...
Stanislaw
------------------------------
Subject: Digest Footer
_______________________________________________
users mailing list
[email protected]
http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
------------------------------
End of users Digest, Vol 49, Issue 23
*************************************
