Rick Macdougall wrote:
Does this patch below look even vaguely correct ? (and of course the
same loop around hash 2 etc)
I've just had my first brief (20 second) look at this plugin code. Your
patch looks reasonable. You'll also need to lose the current alarm
stuff near the end though:
if (defined $oldalarm) {
alarm $oldalarm; $oldalarm = undef;
}
Also, the original plugin, unless I'm blind, seems to have an unbalanced
set of curly braces:
eval {
Mail::SpamAssassin::Util::trap_sigalrm_fully(sub { die
"ixhash timeout reached"; });
$oldalarm = alarm($timeout);
Further, I don't know why it even uses it's own DNS resolver. It would
make much more sense to use SA's and do all this in the background.
Daryl
