On Tue, 29 Dec 2015 17:17:38 -0000, Kevin A. McGrail <kmcgr...@pccc.com> wrote:

On 12/29/2015 7:18 AM, Kevin Golding wrote:

The big thing I've confirmed is the _Y part of the tag is redundant for me, since I see the following in debug:

dbg: check: tagrun - tag TXREP_EMAIL_IP is now ready, value: 0.0

Since tagrun debug output strips the fore and aft _ I've been running with:

add_header TxRep-Email-IP: _TXREP_EMAIL_IP_

I had found the confusion about needing either _U or _G -r neither unclear so it was nice to confirm that neither was the best choice for me. The problem is I still get:

X-Spam-TxRep-Email-IP: _TXREP_EMAIL_IP_

I've tried this with every TXREP_FOO option that I can find and nothing gets translated. All my other template tags work as expected though so I feel there's something awry.

I'm happy to fix the small documentation bugs I've already worked out and I'm happy to submit patches to move it to Mail::SpamAssassin::Conf if desired (although the number of these tags and variations is likely why originally left in the plugin documentation and may still be preferred) but I'm reluctant to be too gung-ho when I can't get the things working myself.
Agreed. I see the code now at 1485. Can anyone else replicate the issue at which point this becomes a bug?

We always need help with the code and docs so don't be afraid to try. You'd open a bug on our bugzilla instance and attach patches there.

My PERSONAL input is that I wouldn't move the tags to the main conf as presumably other plugins have tags but they aren't there. Adding something that says plugins may add additional tags might be good though because I've worked with SA a long time didn't know the tags could be used!


Simplest option is submitted: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7280

Interestingly in submitting that it suggested https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6162 which says template tags can't have underscores, and is still marked as new. It does fit the basic description of the tags I'm struggling with so it seems this may be the bug I was looking for.

I'll try to look properly later.

Kevin

Reply via email to