I was feeling ambitious so I gave this a shot. Here's what I changed: https://github.com/johnament/tomcat85/commit/a0281b2d4e0fea7cb0f7a9d3cd1e750b48498ff2 . I get some failed tests, but generallys eems good (I broke it earlier, and lots of things failed).
[concat] Testsuites with failed tests: [concat] TEST-org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt [concat] TEST-org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt [concat] TEST-org.apache.catalina.startup.TestHostConfigAutomaticDeployment.NIO.txt [concat] TEST-org.apache.catalina.startup.TestHostConfigAutomaticDeployment.NIO2.txt [concat] TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt [concat] TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt [concat] TEST-org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt [concat] TEST-org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt [concat] TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt [concat] TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt [concat] TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt [concat] TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt [concat] TEST-org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt [concat] TEST-org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt [concat] TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt [concat] TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt I'm wondering, can I publish local maven artifacts using the ant build? Would be good to see if this fixes or changes my behavior. John On Wed, Dec 14, 2016 at 12:22 PM Mark Thomas <ma...@apache.org> wrote: > On 14/12/2016 16:23, Christopher Schultz wrote: > > Mark, > > > > On 12/8/16 4:19 AM, Mark Thomas wrote: > >> On 07/12/2016 15:21, Christopher Schultz wrote: > >>> > >>> Hmm... there is the "startStopThreads" setting on the Engine, > >>> but unfortunately there is not (currently available) setting that > >>> says "don't use multiple threads at all". It looks like Tomcat is > >>> always going to use at least one (separate) thread to launch the > >>> various Hosts (and webapps). > > > >> It wouldn't be too hard to change that to not use an executor if > >> the default of startStopThreads="1" was being used. > > > > +1 to running start on the main thread if startStopThreads="1". > > > > Where would I look to start working on a proposed patch? The Tomcat > > Lifecycle isn't my strong suit. > > ContainerBase. Look for uses of startStopThreads.# > > >> However... > > > > Even if this doesn't solve John's problem, I think it's worth doing. > > > > Comments? > > No objections. I'd thought about it previously but it wasn't an itch I > felt the urge to scratch. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > >
