On Sat, Oct 27, 2018 at 1:29 AM Igal Sapir <i...@lucee.org> wrote: > > Woonsan, > > On Fri, Oct 26, 2018 at 2:54 PM Woonsan Ko <woon...@apache.org> wrote: > > > Not sure if it helps, but I've spent some hours to test it out for my > > curiosity. Embedding tomcat v9 with an example servlet is simple > > enough, but it's not working yet with fully initialized Solr: > > - https://github.com/woonsan/solr-tomcat > > > > I noticed that you extend Tomcat [1] in order to avoid initializing the > default servlets. You may have already seen that, but I wanted to point > out that in the next version of Tomcat it can be done by passing false > to setAddDefaultWebXmlToWebapp() > [2].
That's a nice improvement. Thanks for the info. I added a TODO comment above the line. Best, Woonsan > > Best, > > Igal > > [1] > https://github.com/woonsan/solr-tomcat/blob/master/server/src/main/java/com/github/woonsan/solr/server/tomcat/launch/Main.java#L103 > [2] https://github.com/apache/tomcat/commit/0222ce9 > > > > > > I'm not there yet to understand the reasons and have fixes. > > Let me know if you have any suggestions. > > > > Cheers, > > > > Woonsan > > > > On Fri, Oct 19, 2018 at 9:09 AM Shawn Heisey <apa...@elyograg.org> wrote: > > > > > > On 10/18/2018 8:55 AM, Christopher Schultz wrote: > > > > Actually, my goal was to convince the Solr team that switching from > > > > Jetty to Tomcat was (a) possible and (b) possibly attractive. > > > > > > Over on lucene-dev, I had said that I removed jetty from solr's ivy > > > config and found only two classes with errors in eclipse. > > > > > > Turns out this was because I hadn't removed jetty from the *lucene* ivy > > > config, so most of the jetty jars were actually still referenced in the > > > eclipse build path. > > > > > > When I remove jetty from ALL ivy configs, there are 335 compile errors, > > > across many more classes. Some of those are on the Lucene side, where I > > > have less concern. The part of Lucene that utilizes Jetty is not used > > > in Solr. > > > > > > As I expected, a lot of the errors are in test code, but some of them > > > are in code that's not for tests. > > > > > > If you really want to see us switch to Tomcat, we'll need help fixing > > > those errors ... switching the code over to generic APIs (servlet and > > > native Java) where possible, and to Tomcat where necessary. I would not > > > expect the Tomcat community to actually do the work -- just provide > > > expert guidance. Although if anyone was interested in volunteering, I > > > wouldn't turn away the help! > > > > > > Thanks, > > > Shawn > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: users-h...@tomcat.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: users-h...@tomcat.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
