A little background on the original question: we have some legal issues with a client, among other things, he claims that our code isn't documented well, because he run checkstyle on it, and it showed 6000 errors. My argumentation was that default checkstyle settings aren't telling anything about code quality (unless agreed upon upfront). I run checkstyle with default settings on tomcat code base and it showed 85.412 errors using sun code checks (yes, those from 1996). Most of them are like:
AbstractFramedStreamSourceChannel<AjpClientChannel,AbstractAjpClientStreamSourceChannel,AbstractAjpClientStreamSinkChannel> this line produces multiple warnings, for example ',' not followed by a whitespace and such. if(attachments == null) - if not followed by a whitespace etc. Hence if such a mature product like tomcat (with 10.000.000 installations) contains 85412 errors and is considered well documented, he is using the wrong tool for the task. regards Leon On Tue, Feb 5, 2019 at 11:25 AM Leon Rosenberg <rosenberg.l...@gmail.com> wrote: > Thank you very much Igal, Marc and Emmanuel. > > regards > Leon > > On Tue, Feb 5, 2019 at 11:23 AM Emmanuel Bourg <ebo...@apache.org> wrote: > >> Le 05/02/2019 à 00:48, Leon Rosenberg a écrit : >> >> > I vaguely remember Marc naming some figures for number of tomcat >> downloads >> > sofar, but I couldn't find anything in the state of the cat slides. >> > I checked on the website, but all I found was this: >> > >> > " Tomcat has been downloaded more than 10 million times: assuming even >> a 1% >> > production adoption rate results in more than 100000 installations. " >> > But this is from 2014 and I assume there should be a better number by >> now. >> > >> > Anyone? Asking for a friend ;-) >> >> Some numbers, from Debian: >> >> >> https://qa.debian.org/popcon-graph.php?packages=tomcat9+tomcat8+tomcat7+tomcat6&show_installed=on&want_legend=on&want_ticks=on&from_date=&to_date=&hlght_date=&date_fmt=%25Y-%25m&beenhere=1 >> >> around 2400 installations reported by popcon, rather stable over the >> years. >> >> From Ubuntu: >> >> https://popcon.ubuntu.com/by_inst >> >> tomcat6 15785 >> tomcat7 2122 >> tomcat8 117 >> >> And from Netcraft: >> >> >> https://news.netcraft.com/archives/2018/12/17/december-2018-web-server-survey.html >> >> Netcraft reported ~600000 domains served by Tomcat. >> >> Emmanuel Bourg >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: users-h...@tomcat.apache.org >> >>
