-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Leon,
On 2/5/19 05:35, Leon Rosenberg wrote: > A little background on the original question: we have some legal > issues with a client, among other things, he claims that our code > isn't documented well, because he run checkstyle on it, and it > showed 6000 errors. My argumentation was that default checkstyle > settings aren't telling anything about code quality (unless agreed > upon upfront). I run checkstyle with default settings on tomcat > code base and it showed 85.412 errors using sun code checks (yes, > those from 1996). Most of them are like: > > AbstractFramedStreamSourceChannel<AjpClientChannel,AbstractAjpClientSt reamSourceChannel,AbstractAjpClientStreamSinkChannel> > > this line produces multiple warnings, for example ',' not followed by a > whitespace and such. > > if(attachments == null) - if not followed by a whitespace etc. > > Hence if such a mature product like tomcat (with 10.000.000 > installations) contains 85412 errors and is considered well > documented, he is using the wrong tool for the task. LOL try running checkstyle or SpotBugs against WebLogic and see what happens. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlxZny0ACgkQHPApP6U8 pFjfCg//TunspTQM63FupsuF13vm44pVlVBTnK1hibsH8b2Ceyp2GcjOp5LDu17b FZMJ7ZD+b7yER8CZIU0vyQQTH4wHD+CJEJpFhYIKGnw3143mLfmemu5Ni6NCWDWg sagRVuGHEg978MLi+oY9pQOOXBumZbcpA63oIdBUtmddL6E5zfbTq6k0Lw6oPZNZ Ent5axXbMNnnbsihWmbZN7nWx4keASpbsWosvjs5z/mSx4bySIzLDNhM+DJEZcVd R6P52M9DX4renzW5bY7G4qgohBDPdxDB1SOA041SReg5o+nR+VzsG0IYUQ5rlaS4 FiznBzn7GiXp06OPvauugz9sGxj/r3ApzCqHvpGm3o+E0rtxSwKK/cZK/rI+U/Ru 1r0aMc+XkV5mDpqy185zajUeFHqbnwJSxFti1mDxeQbLID9MjhXZxBGbWioVjVvB 1mtRux+KecdbUqHyBjazdu8Khsmwf2M3cOMPKdYLl7jiSz1g59NIjYFZaYjctgZi gMmAC7MjLlo7AQZRNYct/C6FvEh/QcK0ygrKIwwNovYJHp16YwDC51X3Di2Mqe8v CcXxpefQ7FWYkla2CMS7eAVYYeyhjlqrZn8gXGUA3lHmjrhlAJ4TS4nZ0kzXPRn+ xNQGeTU3Ctgz3YXNwgtSyCNVaKRpBraLnhDCsDw+t/IcJGysZ1E= =QQVh -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
