On 05/02/2019 14:51, Garret Wilson wrote: > On 2/3/2019 9:34 PM, Mark Thomas wrote: >> >>> * If this setting is still needed in some cases, is there any way to >>> control it without resorting to a system property? (System >>> properties are not very flexible, and Tomcat has many layers of more >>> manipulable settings, as you all would know better than me.) >> No. Moving system properties to more fine-grained configuration >> locations is on the TODO list. > > > Is there really an actual to-do list, or were you speaking > metaphorically? I'd be interested in looking at it.
https://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?view=annotate > I was crossing my fingers that https://github.com/apache/tomcat would > actually be using the issue tracker, and that would be the to-do list, > but I suppose I was expecting too much. Speaking of which, is the GitHub > repository the canonical place for source code? No. It is a mirror of svn. > Because > https://tomcat.apache.org/svn.html claims that Tomcat still uses > Suversion and that Git is just a read-only mirror, even though > https://git.apache.org/ claims that some projects have switched to > GitHub for their primary SCM. Those statements are all correct. > I'm really interested in contributing, but I shudder at thinking about > regressing a decade to start messing with Subversion (just > `.gitattributes and how it more or less fixes the CRLF nightmare is a > huge thing) and submitting patches rather than commenting on pull > requests. (I have nothing against Subversion, mind you. I thought it was > wonderful and I once used the property system extensively for per-file > metadata in a custom CRM. But for a SCM… the world has moved on.) What's > the Tomcat source code status? Migratation to git has been in planning for a while. We are pretty much ready to pull the trigger. It is largely waiting for someone to have the time to do it when there aren't other more urgent things to be dealt with. I'd expect it to happen in the next few months. However, you can still use git and GitHub and provide PRs against gitub.com/apache/tomcat The ASF has integrations in place that make it fairly easy for us to pull those in. > Returning to the subject, do you have a list of system properties you'd > be interested in making configurable, All of them ;) http://tomcat.apache.org/tomcat-9.0-doc/config/systemprops.html Some are going to be a lot easier to address than others. I suspect that in some cases we'd opt to keep the system property due to the complexity of replacing it. > and would this be a welcome > contribution? Yes. > Where in the code code I look before committing myself? Pick a property and use your IDE (or GitHub, or ...) to see how it is used. Then figure out where to put the replacement configuration. Ask on dev@ if pointers are required. Note: In terms of backward compatibility, we have typically used the system property to set the default of the new config option and then dropped the system property in a subsequent major release. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
