On 10/30/07, John Patterson <[EMAIL PROTECTED]> wrote:
>
>
> On 29 Oct 2007, at 17:37, Eelco Hillenius wrote:
> /
> Also, I was surprised to find that instances of image were stateful
> if I used the constructor Image(String, String) and I had to override
> the getStatelessHint.



yes that looks like a bug
because i you just give a path then this is called:

loadStaticImage(component.getModelObjectAsString());
that makes a ResourceReference
but in bind() we also create again the resource:

// Then dereference the resource

resource = resourceReference.getResource();


thats a bit weird why we do that there.
because the resource shouldn't be used if there is a resource reference,
because
the url to the shared resource is generated:
*

if* (resourceReference != *null*)

{

// Create URL to shared resource

url = RequestCycle.*get*().urlFor(resourceReference, resourceParameters);

}

i guess the:

*public* *final* *boolean* isStateless()

{

*return* resource == *null*;

}



could be reversed: return resourceReference != null

Reply via email to