Oh I wouldn't take out the convenience methods... but the base should not be <String,Object> :)

Start with <String, String> then add any convenience methods from there.
I agree that manual conversion would be a bit of a pain, but most people would only do it once if that was the only option (however its not, so you don't need to discard anything).

- Brill


On 11-Aug-08, at 11:33 AM, Igor Vaynberg wrote:

then, unfortunately, you have to perform the conversion yourself all
the time, which is quiet annoying.

-igor

On Mon, Aug 11, 2008 at 8:24 AM, Brill Pappin <[EMAIL PROTECTED]> wrote:
ok... that make sense to me.
The primary then should be <String, String> but maybe overload it so that
nothing legacy breaks.

I think the <String, ?> will help, but I also think that being specific about what it holds is important... otherwise its trying to be "too smart"
and I might get a string representation that I don't want... if it's
explicitly <String, String> then you always know exactly what is going
in/out.

IMO.

- Brill Pappin


On 11-Aug-08, at 11:07 AM, Igor Vaynberg wrote:

wicket provides convinience methods for working with strings, eg a
method to automatically convert a string to an int so you dont have
to. likewise it will automatically convert all objects you put into it
to a string.

-igor

On Mon, Aug 11, 2008 at 7:36 AM, Lutz Müller <[EMAIL PROTECTED] >
wrote:

Thats what I was thinking, too, when I read Uwes post. I did not look at Wicket 1.4 yet, but had assumed that PageParameters should always be
String to
String maps, because this is what they are in HTTP.
But then again, wicket is not strictly HTTP, and when you look at the
javadoc
comment for PageParameters (at least in 1.3) it explicitly states that PageParameters might be used with other protocols. Maybe this is the
reason
why.

Lutz

On Monday 11 August 2008 02:33:56 Brill Pappin wrote:

I agree on the generics front... however are not the params supposed
to be strings?
or do they represent request parameters as well as page attributes?

If they are representing both, maybe they should be separated.

- Brill

On 8-Aug-08, at 12:59 PM, Uwe Schäfer wrote:

ok, maybe there was too much K and V in my last mail ;)

I´ll try another way round:

wouldn´t it be nice to be able to use smth like that ?

Map<String, Integer> map =...
PageParameters p = new PageParameters(map);

So if you agree, please switch from

public PageParameters(final Map<String, Object> parameterMap)
to
public PageParameters(final Map<String, ?> parameterMap)

thx, uwe

--

THOMAS DAILY GmbH
Adlerstraße 19
79098 Freiburg
Deutschland
T  + 49 761 3 85 59 0
F  + 49 761 3 85 59 550
E  [EMAIL PROTECTED]
www.thomas-daily.de

Geschäftsführer/Managing Directors:
Wendy Thomas, Susanne Larbig
Handelsregister Freiburg i.Br., HRB 3947

Registrieren Sie sich unter http://morningnews.thomas-daily.de für die kostenfreien TD Morning News, eine Auswahl aktueller Themen des
Tages morgens um 9:00 in Ihrer Mailbox.

Hinweis: Der Redaktionsschluss für unsere TD Morning News ist
täglich um 8:30 Uhr. Es werden vorrangig Informationen
berücksichtigt, die nach 16:00 Uhr des Vortages eingegangen sind.
Die Email-Adresse unserer Redaktion lautet [EMAIL PROTECTED] .


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to