What we actually want to do is, to use the regular converter for Date.class with a small addition. The converter uses a DateFormat. We want to set this DateFormat: setLenient(true). I thought to put it in the application scope as we want this everywhere in the application. Following this thread, I start thinking that your previous suggestion is the best solution for us: just override the getConverter.
Eyal Golan [email protected] Visit: http://jvdrums.sourceforge.net/ LinkedIn: http://www.linkedin.com/in/egolan74 P Save a tree. Please don't print this e-mail unless it's really necessary On Thu, May 7, 2009 at 9:36 PM, Igor Vaynberg <[email protected]>wrote: > problem is datetextfield suppports different formats which require > different converters, so it is a bit of a special case with regard to > using a global date converter. > > -igor > > On Thu, May 7, 2009 at 11:16 AM, Eyal Golan <[email protected]> wrote: > > "if you want to use your own converter then override getconverter() and > > return whatever you like." > > > > True. This is what I suggested my mate when we discussed it. And I guess > > this what we'll do. > > But isn't using a converter for the whole application eliminates the need > to > > create a custom component? > > > > Thanks > > > > > > Eyal Golan > > [email protected] > > > > Visit: http://jvdrums.sourceforge.net/ > > LinkedIn: http://www.linkedin.com/in/egolan74 > > > > P Save a tree. Please don't print this e-mail unless it's really > necessary > > > > > > On Thu, May 7, 2009 at 6:16 PM, Igor Vaynberg <[email protected] > >wrote: > > > >> if you want to use your own converter then override getconverter() and > >> return whatever you like. > >> > >> -igor > >> > >> On Thu, May 7, 2009 at 1:38 AM, Eyal Golan <[email protected]> wrote: > >> > I'm going to review on Sunday the code my team mate has made . > >> > I'll be able to give you more information and see if maybe we > >> misunderstood > >> > something. > >> > > >> > > >> > Eyal Golan > >> > [email protected] > >> > > >> > Visit: http://jvdrums.sourceforge.net/ > >> > LinkedIn: http://www.linkedin.com/in/egolan74 > >> > > >> > P Save a tree. Please don't print this e-mail unless it's really > >> necessary > >> > > >> > > >> > On Wed, May 6, 2009 at 6:43 PM, Igor Vaynberg < > [email protected] > >> >wrote: > >> > > >> >> what is the full name of this class? there are two DateTextField > >> >> classes in wicket codebase. > >> >> > >> >> -igor > >> >> > >> >> On Tue, May 5, 2009 at 9:51 AM, Eyal Golan <[email protected]> > wrote: > >> >> > Hello, > >> >> > We use Wicket 1.3.5 and I found something annoying with the > >> >> DateTextField. > >> >> > In the constructor of that class, the converter is created > internally. > >> >> > If I want to use my own converter, I need to inherit DateTextField, > >> add a > >> >> > converter as a member, and return it in the getConverter method. > >> >> > > >> >> > Why not have a protected method (that can be overridden) that > returns > >> the > >> >> > converter: > >> >> > Instead of: > >> >> > public DateTextField(String id, IModel model, String > datePattern) > >> >> > { > >> >> > super(id, model, Date.class); > >> >> > this.datePattern = datePattern; > >> >> > *this.converter = new DateConverter() > >> >> > { > >> >> > private static final long serialVersionUID = 1L; > >> >> > > >> >> > /** > >> >> > * @see > >> >> > > >> >> > >> > org.apache.wicket.util.convert.converters.DateConverter#getDateFormat(java.util.Locale) > >> >> > */ > >> >> > public DateFormat getDateFormat(Locale locale) > >> >> > { > >> >> > return new > >> >> SimpleDateFormat(DateTextField.this.datePattern); > >> >> > } > >> >> > };* > >> >> > } > >> >> > > >> >> > Do something like: > >> >> > public DateTextField(String id, IModel model, String > datePattern) > >> >> > { > >> >> > super(id, model, Date.class); > >> >> > this.datePattern = datePattern; > >> >> > *this.converter = newDateConverter();* > >> >> > } > >> >> > and > >> >> > > >> >> > protected newDateConverter() { > >> >> > return new DateConverter() > >> >> > { > >> >> > private static final long serialVersionUID = 1L; > >> >> > > >> >> > /** > >> >> > * @see > >> >> > > >> >> > >> > org.apache.wicket.util.convert.converters.DateConverter#getDateFormat(java.util.Locale) > >> >> > */ > >> >> > public DateFormat getDateFormat(Locale locale) > >> >> > { > >> >> > return new > >> >> SimpleDateFormat(DateTextField.this.datePattern); > >> >> > } > >> >> > }; > >> >> > } > >> >> > > >> >> > BTW, I know that we can also use the newConverterLocator() in our > >> >> > application. > >> >> > > >> >> > Do you think I should open a JIRA issue with 'wish' for that? > >> >> > > >> >> > > >> >> > Eyal Golan > >> >> > [email protected] > >> >> > > >> >> > Visit: http://jvdrums.sourceforge.net/ > >> >> > LinkedIn: http://www.linkedin.com/in/egolan74 > >> >> > > >> >> > P Save a tree. Please don't print this e-mail unless it's really > >> >> necessary > >> >> > > >> >> > >> >> --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: [email protected] > >> >> For additional commands, e-mail: [email protected] > >> >> > >> >> > >> > > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
