I'd just like to pass this on to everyone on the list. Pedro Santos has been added as a committer and PMC member for Apache Wicket. Pedro has been increasingly active in the Wicket community in recent months, and his patches continue to improve in quality. Additionally, Pedro is always willing to do the "grunt work" of creating great test cases for his patches, or for JIRA issues that others have attached patches to. Test cases are invaluable to the development of Wicket because they help us not introduce regressions as we fix bugs and add features.
Thanks Pedro, and we look forward to working with you! PS - the message below is Pedro's first commit to Wicket - already improving test cases! -- Jeremy Thomerson http://wickettraining.com Need a CMS for Wicket? Use Brix! http://brixcms.org ---------- Forwarded message ---------- From: <pe...@apache.org> Date: Mon, Nov 22, 2010 at 5:45 PM Subject: svn commit: r1037925 - in /wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree: MoveChildToParentNodeMarkedForRecreationTest.java MoveChildToParentNodeMarkedForRecreationTestPage.java To: comm...@wicket.apache.org Author: pedro Date: Mon Nov 22 22:45:41 2010 New Revision: 1037925 URL: http://svn.apache.org/viewvc?rev=1037925&view=rev Log: adding an assert line in the test to turn it more meaningful Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java?rev=1037925&r1=1037924&r2=1037925&view=diff ============================================================================== --- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java (original) +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTest.java Mon Nov 22 22:45:41 2010 @@ -38,7 +38,9 @@ public class MoveChildToParentNodeMarked public void test() { WicketTester tester = new WicketTester(); - tester.startPage(MoveChildToParentNodeMarkedForRecreationTestPage.class); + MoveChildToParentNodeMarkedForRecreationTestPage testPage = new MoveChildToParentNodeMarkedForRecreationTestPage(); + tester.startPage(testPage); tester.clickLink("moveC3ToC2"); + assertTrue(testPage.c2.isNodeChild(testPage.c3)); } } Modified: wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java?rev=1037925&r1=1037924&r2=1037925&view=diff ============================================================================== --- wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java (original) +++ wicket/branches/wicket-1.4.x/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java Mon Nov 22 22:45:41 2010 @@ -28,8 +28,8 @@ public class MoveChildToParentNodeMarked private static final long serialVersionUID = 1L; private final Tree treeTable; - private DefaultMutableTreeNode c2; - private DefaultMutableTreeNode c3; + DefaultMutableTreeNode c2; + DefaultMutableTreeNode c3; public MoveChildToParentNodeMarkedForRecreationTestPage() { --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
